Skip to content

8253952: Refine ZipOutputStream.putNextEntry() to recalculate ZipEntry's compressed size #2765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

vieiro
Copy link
Contributor

@vieiro vieiro commented Jun 12, 2024

Backport of JDK-8253952

Clean backport with a minor conflict resolved. Tests pass cleanly.

I have a test case that shows differences in behaviour between Amazon Corretto 11.0.23.9-1 (built with --zlib=system) and adoptium-jdk-11.0.23+9 (built with --zlib=bundled) on Fedora 40 with system-wide zlib-ng. Let me know if you think it's worth adding the test case to the codebase.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8253952 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires a CSR request matching fixVersion 11.0.25 to be approved (needs to be created)

Issue

  • JDK-8253952: Refine ZipOutputStream.putNextEntry() to recalculate ZipEntry's compressed size (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2765/head:pull/2765
$ git checkout pull/2765

Update a local copy of the PR:
$ git checkout pull/2765
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2765/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2765

View PR using the GUI difftool:
$ git pr show -t 2765

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2765.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 12, 2024

👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 12, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 60159cff407255bfa546d98d423e8ab2e83eb0e3 8253952: Refine ZipOutputStream.putNextEntry() to recalculate ZipEntry's compressed size Jun 12, 2024
@openjdk
Copy link

openjdk bot commented Jun 12, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Jun 12, 2024
@openjdk
Copy link

openjdk bot commented Jun 12, 2024

At least one of the issues associated with this backport has a resolved CSR for a different version. As this means that this backport may also need a CSR, the csr label is being added to this pull request to signal this potential requirement. The command /csr unneeded can be used to remove the label in case a CSR is not needed.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Jun 12, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 12, 2024

Webrevs

@vieiro
Copy link
Contributor Author

vieiro commented Jun 12, 2024

/approval JDK-8253952 request Refine ZipOutputStream.putNextEntry() to recalculate ZipEntry's compressed size

@openjdk
Copy link

openjdk bot commented Jun 12, 2024

@vieiro
JDK-8253952: The approval request has been created successfully.

@openjdk openjdk bot added approval and removed approval labels Jun 12, 2024
@vieiro
Copy link
Contributor Author

vieiro commented Jun 13, 2024

This PR requires a CSR! I don't think it's worth the hassle for such a small corner-case. Closing as a consequence. Apologies for the trouble.

@vieiro vieiro closed this Jun 13, 2024
@vieiro vieiro deleted the backports/JDK-8253952 branch September 5, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport csr Pull request needs approved CSR before integration rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant