Skip to content

Conversation

@amosshi
Copy link
Contributor

@amosshi amosshi commented Jun 14, 2024

Backport of JDK-8305079

Testing

  • Local: Test passed on MacOS 14.5
    • Test7190310.java: Test results: passed: 1
  • Pipeline: All checks have passed
  • Testing Machine: SAP nightlies passed on 2024-06-20
    • jtreg_hotspot_tier1: compiler/c2/Test7190310.java: SUCCESSFUL GitHub 📊⏲ - [2,918 msec]

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8305079 needs maintainer approval

Issue

  • JDK-8305079: Remove finalize() from compiler/c2/Test719030 (Sub-task - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2773/head:pull/2773
$ git checkout pull/2773

Update a local copy of the PR:
$ git checkout pull/2773
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2773/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2773

View PR using the GUI difftool:
$ git pr show -t 2773

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2773.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 14, 2024

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 14, 2024

@amosshi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8305079: Remove finalize() from compiler/c2/Test719030

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 33 new commits pushed to the master branch:

  • 7e1e239: 8315898: Open source swing JMenu tests
  • 4a28ac0: 8306060: Open source few AWT Insets related tests
  • b0ad167: 8306850: Open source AWT Modal related tests
  • e726fe7: 8332936: Test vmTestbase/metaspace/gc/watermark_70_80/TestDescription.java fails with no GC's recorded
  • 9f58121: 8328560: java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports Applet
  • e541cbd: 8320079: The ArabicBox.java test has no control buttons
  • 0e74e1b: 8327137: Add test for ConcurrentModificationException in BasicDirectoryModel
  • cc54dc6: 8331063: Some HttpClient tests don't report leaks
  • ddeb602: 8327840: Automate javax/swing/border/Test4129681.java
  • b396665: 8328011: Convert java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to main
  • ... and 23 more: https://git.openjdk.org/jdk11u-dev/compare/2ded016d40254334ad39dd3bf3e62803060cd4fb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 84df74ca3948c50d8e6f24694310860ed3888aba 8305079: Remove finalize() from compiler/c2/Test719030 Jun 14, 2024
@openjdk
Copy link

openjdk bot commented Jun 14, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 14, 2024
@openjdk
Copy link

openjdk bot commented Jun 14, 2024

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 14, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 14, 2024

Webrevs

@amosshi
Copy link
Contributor Author

amosshi commented Jun 21, 2024

/approval request "Backporting for parity with 11.0.25-oracle. No risk, test fix. Clean backport. Test passes and SAP nightlies pass on 2024-06-20”

@openjdk
Copy link

openjdk bot commented Jun 21, 2024

@amosshi
8305079: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jun 21, 2024
@amosshi
Copy link
Contributor Author

amosshi commented Jun 25, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jun 25, 2024

Going to push as commit 569c669.
Since your change was applied there have been 40 commits pushed to the master branch:

  • 724477c: 8305081: Remove finalize() from test/hotspot/jtreg/compiler/runtime/Test8168712
  • cc42090: 8306466: Open source more AWT Drag & Drop related tests
  • 8489b52: 8316462: sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java ignores VM flags
  • f8e87df: 8268906: gc/g1/mixedgc/TestOldGenCollectionUsage.java assumes that GCs take 1ms minimum
  • 3b4f583: 8269428: java/util/concurrent/ConcurrentHashMap/ToArray.java timed out
  • 7198ea1: 8299487: Test java/net/httpclient/whitebox/SSLTubeTestDriver.java timed out
  • 2a5ba0a: 8328115: Convert java/awt/font/TextLayout/TestJustification.html applet test to main
  • 7e1e239: 8315898: Open source swing JMenu tests
  • 4a28ac0: 8306060: Open source few AWT Insets related tests
  • b0ad167: 8306850: Open source AWT Modal related tests
  • ... and 30 more: https://git.openjdk.org/jdk11u-dev/compare/2ded016d40254334ad39dd3bf3e62803060cd4fb...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 25, 2024
@openjdk openjdk bot closed this Jun 25, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 25, 2024
@openjdk
Copy link

openjdk bot commented Jun 25, 2024

@amosshi Pushed as commit 569c669.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@amosshi amosshi deleted the backport-8305079 branch August 8, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant