Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport fcd7fb74c7654956660082c83e42d2262478a1e5 #2778

Closed
wants to merge 3 commits into from

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Jun 14, 2024

I backport this for parity with 11.0.25-oracle.
The test is limit to Windows, so backport with JDK-8331495 together.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8331495 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8331142 needs maintainer approval

Issues

  • JDK-8331142: Add test for number of loader threads in BasicDirectoryModel (Bug - P4)
  • JDK-8331495: Limit BasicDirectoryModel/LoaderThreadCount.java to Windows only (Sub-task - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2778/head:pull/2778
$ git checkout pull/2778

Update a local copy of the PR:
$ git checkout pull/2778
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2778/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2778

View PR using the GUI difftool:
$ git pr show -t 2778

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2778.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 14, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@luchenlin
Copy link
Contributor Author

/issue add JDK-8331495

@openjdk
Copy link

openjdk bot commented Jun 14, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport b2fb5ea13ba5087411410519213fc953ecc44618 8331142: Add test for number of loader threads in BasicDirectoryModel Jun 14, 2024
@openjdk
Copy link

openjdk bot commented Jun 14, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 14, 2024
@openjdk
Copy link

openjdk bot commented Jun 14, 2024

@luchenlin
Adding additional issue to issue list: 8331495: Limit BasicDirectoryModel/LoaderThreadCount.java to Windows only.

@mlbridge
Copy link

mlbridge bot commented Jun 14, 2024

Webrevs

@luchenlin luchenlin closed this Jun 18, 2024
@TheRealMDoerr
Copy link
Contributor

This test is wrong for 11u: LoaderThreadCount.java:231: error: ';' expected
"record" is a feature which is unavailable in 11u and needs to get replaced. Note the test only runs on Windows.

@luchenlin luchenlin reopened this Jun 19, 2024
@luchenlin luchenlin changed the title 8331142: Add test for number of loader threads in BasicDirectoryModel Backport fcd7fb74c7654956660082c83e42d2262478a1e5 Jun 19, 2024
@luchenlin luchenlin closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
2 participants