-
Notifications
You must be signed in to change notification settings - Fork 238
8264016: [JVMCI] add some thread local fields for use by JVMCI #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me. Please try to build without JVMCI too, for extra sanity?
@jerboaa This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Sure, done. Works fine here :) |
/integrate |
Going to push as commit 1f6eb0f.
Your commit was automatically rebased without conflicts. |
Please review this JVMCI-related backport for OpenJDK 11u. It adds some thread-local fields and is useful so as to be able to run graal js on stock OpenJDK. The JDK 17 patch didn't apply clean due to context differences, which got fairly trivially resolved.
Testing: test/hotspot/jtreg/compiler/jvmci and manual test using upstream Graal unit test.
Thoughts?
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/278/head:pull/278
$ git checkout pull/278
Update a local copy of the PR:
$ git checkout pull/278
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/278/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 278
View PR using the GUI difftool:
$ git pr show -t 278
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/278.diff