Skip to content

8306566: Open source several clipboard AWT tests#2781

Closed
vieiro wants to merge 1 commit intoopenjdk:masterfrom
vieiro:backports/JDK-8306566
Closed

8306566: Open source several clipboard AWT tests#2781
vieiro wants to merge 1 commit intoopenjdk:masterfrom
vieiro:backports/JDK-8306566

Conversation

@vieiro
Copy link
Contributor

@vieiro vieiro commented Jun 14, 2024

Clean backport of JDK-8306566 for parity with Oracle 11.0.24

All five tests pass in Linux/Gnome and Windows 11.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8306566 needs maintainer approval

Issue

  • JDK-8306566: Open source several clipboard AWT tests (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2781/head:pull/2781
$ git checkout pull/2781

Update a local copy of the PR:
$ git checkout pull/2781
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2781/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2781

View PR using the GUI difftool:
$ git pr show -t 2781

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2781.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 14, 2024

👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 14, 2024

@vieiro This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8306566: Open source several clipboard AWT tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • f874da3: 8328953: JEditorPane.read throws ChangedCharSetException
  • 014fe94: 8308184: Launching java with large number of jars in classpath with java.protocol.handler.pkgs system property set can lead to StackOverflowError
  • 667bbd3: 8205076: [17u] Inet6AddressImpl.c: lookupIfLocalHost accesses int InetAddress.preferIPv6Address as a boolean
  • 7d4ef49: 8329510: Update ProblemList for JFileChooser/8194044/FileSystemRootTest.java
  • 2e4179b: 8325179: Race in BasicDirectoryModel.validateFileCache

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 136dad7197a1969b2b1fc325f4336c20386c5d3b 8306566: Open source several clipboard AWT tests Jun 14, 2024
@openjdk
Copy link

openjdk bot commented Jun 14, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 14, 2024
@openjdk
Copy link

openjdk bot commented Jun 14, 2024

⚠️ @vieiro This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 14, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 14, 2024

Webrevs

@vieiro
Copy link
Contributor Author

vieiro commented Jun 14, 2024

/approval JDK-8306566 request clean backport for parity with 11.0.24-oracle

@openjdk
Copy link

openjdk bot commented Jun 14, 2024

@vieiro
JDK-8306566: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jun 14, 2024
@vieiro
Copy link
Contributor Author

vieiro commented Jun 17, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 17, 2024
@openjdk
Copy link

openjdk bot commented Jun 17, 2024

@vieiro
Your change (at version d526f3b) is now ready to be sponsored by a Committer.

@TheRealMDoerr
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 17, 2024

Going to push as commit 9b67f2f.
Since your change was applied there have been 5 commits pushed to the master branch:

  • f874da3: 8328953: JEditorPane.read throws ChangedCharSetException
  • 014fe94: 8308184: Launching java with large number of jars in classpath with java.protocol.handler.pkgs system property set can lead to StackOverflowError
  • 667bbd3: 8205076: [17u] Inet6AddressImpl.c: lookupIfLocalHost accesses int InetAddress.preferIPv6Address as a boolean
  • 7d4ef49: 8329510: Update ProblemList for JFileChooser/8194044/FileSystemRootTest.java
  • 2e4179b: 8325179: Race in BasicDirectoryModel.validateFileCache

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 17, 2024
@openjdk openjdk bot closed this Jun 17, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 17, 2024
@openjdk
Copy link

openjdk bot commented Jun 17, 2024

@TheRealMDoerr @vieiro Pushed as commit 9b67f2f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@vieiro vieiro deleted the backports/JDK-8306566 branch September 5, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants