Skip to content

Conversation

@luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Jun 18, 2024

I backport this for parity with 11.0.25-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8332936 needs maintainer approval

Issue

  • JDK-8332936: Test vmTestbase/metaspace/gc/watermark_70_80/TestDescription.java fails with no GC's recorded (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2787/head:pull/2787
$ git checkout pull/2787

Update a local copy of the PR:
$ git checkout pull/2787
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2787/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2787

View PR using the GUI difftool:
$ git pr show -t 2787

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2787.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 18, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 18, 2024

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8332936: Test vmTestbase/metaspace/gc/watermark_70_80/TestDescription.java fails with no GC's recorded

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • b396665: 8328011: Convert java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to main
  • fcff4a9: 8334335: [TESTBUG] Backport of 8279164 to 11u & 17u includes elements of JDK-8163327
  • b0a09bf: 8276306: jdk/jshell/CustomInputToolBuilder.java fails intermittently on storage acquisition
  • 582159a: 8306432: Open source several AWT Text Component related tests
  • ef08f4e: 8320570: NegativeArraySizeException decoding >1G UTF8 bytes with non-ascii characters
  • f6e838d: 8327787: Convert javax/swing/border/Test4129681.java applet test to main
  • 6059f56: 8306489: Open source AWT List related tests
  • 9b67f2f: 8306566: Open source several clipboard AWT tests
  • f874da3: 8328953: JEditorPane.read throws ChangedCharSetException
  • 014fe94: 8308184: Launching java with large number of jars in classpath with java.protocol.handler.pkgs system property set can lead to StackOverflowError
  • ... and 3 more: https://git.openjdk.org/jdk11u-dev/compare/f08e5e87938d3f20575ef186f4eefeb9faeb6e80...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 5ed0d52c8424dd2e7f1ac2404e9fabb40c8402b8 8332936: Test vmTestbase/metaspace/gc/watermark_70_80/TestDescription.java fails with no GC's recorded Jun 18, 2024
@openjdk
Copy link

openjdk bot commented Jun 18, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 18, 2024
@openjdk
Copy link

openjdk bot commented Jun 18, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 18, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 18, 2024

Webrevs

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jun 19, 2024
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 24, 2024

Going to push as commit e726fe7.
Since your change was applied there have been 18 commits pushed to the master branch:

  • 9f58121: 8328560: java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports Applet
  • e541cbd: 8320079: The ArabicBox.java test has no control buttons
  • 0e74e1b: 8327137: Add test for ConcurrentModificationException in BasicDirectoryModel
  • cc54dc6: 8331063: Some HttpClient tests don't report leaks
  • ddeb602: 8327840: Automate javax/swing/border/Test4129681.java
  • b396665: 8328011: Convert java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to main
  • fcff4a9: 8334335: [TESTBUG] Backport of 8279164 to 11u & 17u includes elements of JDK-8163327
  • b0a09bf: 8276306: jdk/jshell/CustomInputToolBuilder.java fails intermittently on storage acquisition
  • 582159a: 8306432: Open source several AWT Text Component related tests
  • ef08f4e: 8320570: NegativeArraySizeException decoding >1G UTF8 bytes with non-ascii characters
  • ... and 8 more: https://git.openjdk.org/jdk11u-dev/compare/f08e5e87938d3f20575ef186f4eefeb9faeb6e80...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 24, 2024
@openjdk openjdk bot closed this Jun 24, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 24, 2024
@openjdk
Copy link

openjdk bot commented Jun 24, 2024

@luchenlin Pushed as commit e726fe7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant