Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315898: Open source swing JMenu tests #2793

Closed
wants to merge 1 commit into from

Conversation

vieiro
Copy link
Contributor

@vieiro vieiro commented Jun 18, 2024

Backport of JDK-8315898 for parity with 11.0.24-oracle.

All tests pass in Linux/Gnome and Windows 11.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8315898 needs maintainer approval

Issue

  • JDK-8315898: Open source swing JMenu tests (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2793/head:pull/2793
$ git checkout pull/2793

Update a local copy of the PR:
$ git checkout pull/2793
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2793/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2793

View PR using the GUI difftool:
$ git pr show -t 2793

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2793.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 18, 2024

👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 18, 2024

@vieiro This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8315898: Open source swing JMenu tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • fcff4a9: 8334335: [TESTBUG] Backport of 8279164 to 11u & 17u includes elements of JDK-8163327
  • b0a09bf: 8276306: jdk/jshell/CustomInputToolBuilder.java fails intermittently on storage acquisition
  • 582159a: 8306432: Open source several AWT Text Component related tests

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport fecd2fd8f26d0e8905a519e30e9aa171683c9df1 8315898: Open source swing JMenu tests Jun 18, 2024
@openjdk
Copy link

openjdk bot commented Jun 18, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 18, 2024

⚠️ @vieiro This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 18, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 18, 2024

Webrevs

@vieiro
Copy link
Contributor Author

vieiro commented Jun 18, 2024

/approval request JDK-8315898 for parity with 11.0.24-oracle.

@openjdk
Copy link

openjdk bot commented Jun 18, 2024

@vieiro
8315898: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jun 18, 2024
@vieiro
Copy link
Contributor Author

vieiro commented Jun 20, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 20, 2024
@openjdk
Copy link

openjdk bot commented Jun 20, 2024

@vieiro
Your change (at version 7de8f78) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 24, 2024

Going to push as commit 7e1e239.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 4a28ac0: 8306060: Open source few AWT Insets related tests
  • b0ad167: 8306850: Open source AWT Modal related tests
  • e726fe7: 8332936: Test vmTestbase/metaspace/gc/watermark_70_80/TestDescription.java fails with no GC's recorded
  • 9f58121: 8328560: java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports Applet
  • e541cbd: 8320079: The ArabicBox.java test has no control buttons
  • 0e74e1b: 8327137: Add test for ConcurrentModificationException in BasicDirectoryModel
  • cc54dc6: 8331063: Some HttpClient tests don't report leaks
  • ddeb602: 8327840: Automate javax/swing/border/Test4129681.java
  • b396665: 8328011: Convert java/awt/Frame/GetBoundsResizeTest/GetBoundsResizeTest.java applet test to main
  • fcff4a9: 8334335: [TESTBUG] Backport of 8279164 to 11u & 17u includes elements of JDK-8163327
  • ... and 2 more: https://git.openjdk.org/jdk11u-dev/compare/ef08f4ebff2e856122fd308a9bb5be3e53e4d8de...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 24, 2024
@openjdk openjdk bot closed this Jun 24, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 24, 2024
@openjdk
Copy link

openjdk bot commented Jun 24, 2024

@shipilev @vieiro Pushed as commit 7e1e239.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@vieiro vieiro deleted the backports/JDK-8315898 branch September 5, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants