-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8268127: Shenandoah: Heap size may be too small for region to align to large page size #28
Conversation
👋 Welcome back zgu! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
/integrate |
@zhengyu123 This PR has not yet been marked as ready for integration. |
@zhengyu123 This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 57d8e1e.
Your commit was automatically rebased without conflicts. |
@zhengyu123 Pushed as commit 57d8e1e. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
I would like to backport this Shenandoah specific patch to 11u, which allows to fallback to regular pages for regions, if heap size is too small to allow regions to use large pages.
The original patch does not apply cleanly, resolved then manually.
Test:
Manually test to ensure large pages are used. Failed w/o the patch and passed with it.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/28/head:pull/28
$ git checkout pull/28
Update a local copy of the PR:
$ git checkout pull/28
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/28/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28
View PR using the GUI difftool:
$ git pr show -t 28
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/28.diff