Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8299487: Test java/net/httpclient/whitebox/SSLTubeTestDriver.java timed out #2803

Closed
wants to merge 1 commit into from

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Jun 21, 2024

I backport this for parity with 11.0.25-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8299487 needs maintainer approval

Issue

  • JDK-8299487: Test java/net/httpclient/whitebox/SSLTubeTestDriver.java timed out (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2803/head:pull/2803
$ git checkout pull/2803

Update a local copy of the PR:
$ git checkout pull/2803
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2803/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2803

View PR using the GUI difftool:
$ git pr show -t 2803

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2803.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 21, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 21, 2024

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8299487: Test java/net/httpclient/whitebox/SSLTubeTestDriver.java timed out

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 2a5ba0a: 8328115: Convert java/awt/font/TextLayout/TestJustification.html applet test to main
  • 7e1e239: 8315898: Open source swing JMenu tests
  • 4a28ac0: 8306060: Open source few AWT Insets related tests
  • b0ad167: 8306850: Open source AWT Modal related tests
  • e726fe7: 8332936: Test vmTestbase/metaspace/gc/watermark_70_80/TestDescription.java fails with no GC's recorded
  • 9f58121: 8328560: java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports Applet
  • e541cbd: 8320079: The ArabicBox.java test has no control buttons
  • 0e74e1b: 8327137: Add test for ConcurrentModificationException in BasicDirectoryModel
  • cc54dc6: 8331063: Some HttpClient tests don't report leaks
  • ddeb602: 8327840: Automate javax/swing/border/Test4129681.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 81083a0e10d9c92f5247ae256e170709014b596b 8299487: Test java/net/httpclient/whitebox/SSLTubeTestDriver.java timed out Jun 21, 2024
@openjdk
Copy link

openjdk bot commented Jun 21, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 21, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 21, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 21, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jun 24, 2024
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 25, 2024

Going to push as commit 7198ea1.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 2a5ba0a: 8328115: Convert java/awt/font/TextLayout/TestJustification.html applet test to main
  • 7e1e239: 8315898: Open source swing JMenu tests
  • 4a28ac0: 8306060: Open source few AWT Insets related tests
  • b0ad167: 8306850: Open source AWT Modal related tests
  • e726fe7: 8332936: Test vmTestbase/metaspace/gc/watermark_70_80/TestDescription.java fails with no GC's recorded
  • 9f58121: 8328560: java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports Applet
  • e541cbd: 8320079: The ArabicBox.java test has no control buttons
  • 0e74e1b: 8327137: Add test for ConcurrentModificationException in BasicDirectoryModel
  • cc54dc6: 8331063: Some HttpClient tests don't report leaks
  • ddeb602: 8327840: Automate javax/swing/border/Test4129681.java

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 25, 2024
@openjdk openjdk bot closed this Jun 25, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 25, 2024
@openjdk
Copy link

openjdk bot commented Jun 25, 2024

@luchenlin Pushed as commit 7198ea1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant