Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns #2805

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Jun 21, 2024


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8326140 needs maintainer approval

Issue

  • JDK-8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2805/head:pull/2805
$ git checkout pull/2805

Update a local copy of the PR:
$ git checkout pull/2805
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2805/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2805

View PR using the GUI difftool:
$ git pr show -t 2805

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2805.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 21, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 21, 2024

@MBaesken This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport d9ef16dbb6917a4fff7711b32f3dd87611560dd1 8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns Jun 21, 2024
@openjdk
Copy link

openjdk bot commented Jun 21, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean approval rfr Pull request is ready for review labels Jun 21, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 21, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jun 21, 2024
@MBaesken
Copy link
Member Author

MBaesken commented Jul 2, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jul 2, 2024

Going to push as commit d88cf4f.
Since your change was applied there have been 31 commits pushed to the master branch:

  • 99435be: 8325876: crashes in docker container tests on Linuxppc64le Power8 machines
  • 2bbdc8c: 8325862: set -XX:+ErrorFileToStderr when executing java in containers for some container related jtreg tests
  • 3c9e960: 8279337: The MToolkit is still referenced in a few places
  • 468d6a7: 8222005: ClassRedefinition crashes with: guarantee(false) failed: OLD and/or OBSOLETE method(s) found
  • 2a5a4d7: 8078725: method adjustments can be done just once for all classes involved into redefinition
  • 3702e90: 8276036: The value of full_count in the message of insufficient codecache is wrong
  • f9d7601: 8328110: Allow simultaneous use of PassFailJFrame with split UI and additional windows
  • db9e313: 8236917: TestInstanceKlassSize.java fails with "The size computed by SA for java.lang.Object does not match"
  • 8578e12: 8303466: C2: failed: malformed control flow. Limit type made precise with MaxL/MinL
  • 6547a16: 8227122: [TESTBUG] Create Docker sidecar test cases
  • ... and 21 more: https://git.openjdk.org/jdk11u-dev/compare/b39666590c86bab10e2b4c4016a56277553e5a58...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 2, 2024
@openjdk openjdk bot closed this Jul 2, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 2, 2024
@openjdk
Copy link

openjdk bot commented Jul 2, 2024

@MBaesken Pushed as commit d88cf4f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant