Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8250824: AArch64: follow up for JDK-8248414 #281

Conversation

VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Aug 24, 2021

Clean backport to jdk11u-dev


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/281/head:pull/281
$ git checkout pull/281

Update a local copy of the PR:
$ git checkout pull/281
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/281/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 281

View PR using the GUI difftool:
$ git pr show -t 281

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/281.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 24, 2021

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d9abf606d9a3156574ca87846e7580a4092c815b 8250824: AArch64: follow up for JDK-8248414 Aug 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 24, 2021

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 24, 2021

@VladimirKempik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8250824: AArch64: follow up for JDK-8248414

The original change missed to update an assert.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 174 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Aug 24, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 24, 2021

Webrevs

@rnkovacs
Copy link
Contributor

@rnkovacs rnkovacs commented Aug 24, 2021

Thank you!

@VladimirKempik
Copy link
Author

@VladimirKempik VladimirKempik commented Aug 24, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 24, 2021

Going to push as commit 8afb159.
Since your change was applied there have been 182 commits pushed to the master branch:

  • 6a6e00e: 8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux
  • 83d916e: 8272772: Shenandoah: compiler/c2/aarch64/TestVolatilesShenandoah.java fails in 11u
  • 417b388: 8272472: StackGuardPages test doesn't build with glibc 2.34
  • a27ee49: 8270096: Shenandoah: Optimize gc/shenandoah/TestRefprocSanity.java for interpreter mode
  • 4a2cd36: 8252853: AArch64: gc/shenandoah/TestVerifyJCStress.java fails intermittently with C1
  • 519894a: 8269478: Shenandoah: gc/shenandoah/mxbeans tests should be more resilient
  • 2d6c976: 8225790: Two NestedDialogs tests fail on Ubuntu
  • 7b72611: 8213007: Update the link in test/jdk/sun/security/provider/SecureRandom/DrbgCavp.java
  • bf01efa: 8248414: AArch64: Remove uses of long and unsigned long ints
  • dfb67bc: 8248682: AArch64: Use ATTRIBUTE_ALIGNED helper
  • ... and 172 more: https://git.openjdk.java.net/jdk11u-dev/compare/0e4fdcf11ad65d2515a78e30eb9f3d81451004b8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 24, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 24, 2021

@VladimirKempik Pushed as commit 8afb159.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants