Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8306466: Open source more AWT Drag & Drop related tests #2810

Closed
wants to merge 1 commit into from

Conversation

vieiro
Copy link
Contributor

@vieiro vieiro commented Jun 24, 2024

Clean backport of JDK-8306466 for parity with Oracle 11.0.24.

All five tests pass in Linux/Gnome and Windows 11.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8306466 needs maintainer approval

Issue

  • JDK-8306466: Open source more AWT Drag & Drop related tests (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2810/head:pull/2810
$ git checkout pull/2810

Update a local copy of the PR:
$ git checkout pull/2810
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2810/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2810

View PR using the GUI difftool:
$ git pr show -t 2810

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2810.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 24, 2024

👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 24, 2024

@vieiro This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8306466: Open source more AWT Drag & Drop related tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 3b4f583: 8269428: java/util/concurrent/ConcurrentHashMap/ToArray.java timed out
  • 7198ea1: 8299487: Test java/net/httpclient/whitebox/SSLTubeTestDriver.java timed out
  • 2a5ba0a: 8328115: Convert java/awt/font/TextLayout/TestJustification.html applet test to main
  • 7e1e239: 8315898: Open source swing JMenu tests
  • 4a28ac0: 8306060: Open source few AWT Insets related tests
  • b0ad167: 8306850: Open source AWT Modal related tests

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 418a82551a2c58e43963beb5aa242a58bbd30e2f 8306466: Open source more AWT Drag & Drop related tests Jun 24, 2024
@openjdk
Copy link

openjdk bot commented Jun 24, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 24, 2024

⚠️ @vieiro This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 24, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 24, 2024

Webrevs

@vieiro
Copy link
Contributor Author

vieiro commented Jun 24, 2024

/approval request JDK-8306466 for parity with Oracle 11.0.24.

Thanks!

@openjdk
Copy link

openjdk bot commented Jun 24, 2024

@vieiro
8306466: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jun 24, 2024
@vieiro
Copy link
Contributor Author

vieiro commented Jun 25, 2024

/integrate
Thanks!

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 25, 2024
@openjdk
Copy link

openjdk bot commented Jun 25, 2024

@vieiro
Your change (at version d01dafc) is now ready to be sponsored by a Committer.

@TheRealMDoerr
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 25, 2024

Going to push as commit cc42090.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 8489b52: 8316462: sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java ignores VM flags
  • f8e87df: 8268906: gc/g1/mixedgc/TestOldGenCollectionUsage.java assumes that GCs take 1ms minimum
  • 3b4f583: 8269428: java/util/concurrent/ConcurrentHashMap/ToArray.java timed out
  • 7198ea1: 8299487: Test java/net/httpclient/whitebox/SSLTubeTestDriver.java timed out
  • 2a5ba0a: 8328115: Convert java/awt/font/TextLayout/TestJustification.html applet test to main
  • 7e1e239: 8315898: Open source swing JMenu tests
  • 4a28ac0: 8306060: Open source few AWT Insets related tests
  • b0ad167: 8306850: Open source AWT Modal related tests

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 25, 2024
@openjdk openjdk bot closed this Jun 25, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 25, 2024
@openjdk
Copy link

openjdk bot commented Jun 25, 2024

@TheRealMDoerr @vieiro Pushed as commit cc42090.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@vieiro vieiro deleted the backports/JDK-8306466 branch September 5, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants