8212597: Optimize String concatenation setup when using primitive operands #2813
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of b3b41df / JDK-8212597
This backport is needed to facilitate clean backports of various String concat improvements that are on todo list for 11 which are otherwise very complex and high risk to rework:
JDK-8212726 Replace some use of drop- and foldArguments with filtering argument combinator in StringConcatFactory
JDK-8213035 Pack MethodHandleInlineStrategy coder and length into a long
JDK-8213478 Reduce rebinds when applying repeated filters and conversions
JDK-8222852 Reduce String concat combinator tree shapes by folding constants into prependers
JDK-8223454 Reduce String concatenation shapes by folding initialLengthCoder into last mixer
This is a clean backport.
Testing: x86_64 build, tier1
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2813/head:pull/2813
$ git checkout pull/2813
Update a local copy of the PR:
$ git checkout pull/2813
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2813/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2813
View PR using the GUI difftool:
$ git pr show -t 2813
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2813.diff
Webrev
Link to Webrev Comment