Skip to content

Conversation

@luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Jun 27, 2024

I backport this for parity with 11.0.25-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8260633 needs maintainer approval

Issue

  • JDK-8260633: [macos] java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.html test failed (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2820/head:pull/2820
$ git checkout pull/2820

Update a local copy of the PR:
$ git checkout pull/2820
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2820/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2820

View PR using the GUI difftool:
$ git pr show -t 2820

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2820.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 27, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 27, 2024

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8260633: [macos] java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.html test failed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • d88cf4f: 8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns
  • 99435be: 8325876: crashes in docker container tests on Linuxppc64le Power8 machines
  • 2bbdc8c: 8325862: set -XX:+ErrorFileToStderr when executing java in containers for some container related jtreg tests
  • 3c9e960: 8279337: The MToolkit is still referenced in a few places
  • 468d6a7: 8222005: ClassRedefinition crashes with: guarantee(false) failed: OLD and/or OBSOLETE method(s) found
  • 2a5a4d7: 8078725: method adjustments can be done just once for all classes involved into redefinition
  • 3702e90: 8276036: The value of full_count in the message of insufficient codecache is wrong
  • f9d7601: 8328110: Allow simultaneous use of PassFailJFrame with split UI and additional windows
  • db9e313: 8236917: TestInstanceKlassSize.java fails with "The size computed by SA for java.lang.Object does not match"
  • 8578e12: 8303466: C2: failed: malformed control flow. Limit type made precise with MaxL/MinL
  • ... and 1 more: https://git.openjdk.org/jdk11u-dev/compare/25d6e19de54f24b4ce39b1481c25a6a9b83bbcac...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 6f7ddbec7d0bc459d44b6518fe1d982eaba7f37b 8260633: [macos] java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.html test failed Jun 27, 2024
@openjdk
Copy link

openjdk bot commented Jun 27, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 27, 2024
@openjdk
Copy link

openjdk bot commented Jun 27, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 27, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 27, 2024

Webrevs

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jun 28, 2024
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 3, 2024

Going to push as commit 7fd48f5.
Since your change was applied there have been 11 commits pushed to the master branch:

  • d88cf4f: 8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns
  • 99435be: 8325876: crashes in docker container tests on Linuxppc64le Power8 machines
  • 2bbdc8c: 8325862: set -XX:+ErrorFileToStderr when executing java in containers for some container related jtreg tests
  • 3c9e960: 8279337: The MToolkit is still referenced in a few places
  • 468d6a7: 8222005: ClassRedefinition crashes with: guarantee(false) failed: OLD and/or OBSOLETE method(s) found
  • 2a5a4d7: 8078725: method adjustments can be done just once for all classes involved into redefinition
  • 3702e90: 8276036: The value of full_count in the message of insufficient codecache is wrong
  • f9d7601: 8328110: Allow simultaneous use of PassFailJFrame with split UI and additional windows
  • db9e313: 8236917: TestInstanceKlassSize.java fails with "The size computed by SA for java.lang.Object does not match"
  • 8578e12: 8303466: C2: failed: malformed control flow. Limit type made precise with MaxL/MinL
  • ... and 1 more: https://git.openjdk.org/jdk11u-dev/compare/25d6e19de54f24b4ce39b1481c25a6a9b83bbcac...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 3, 2024
@openjdk openjdk bot closed this Jul 3, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 3, 2024
@openjdk
Copy link

openjdk bot commented Jul 3, 2024

@luchenlin Pushed as commit 7fd48f5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant