8334711: [TEST_BUG] Compilation failed of MimeFormatsTest/MimeFormatsTest.java

[sashapepin]

Fix the compilation issue in MimeFormatsTest.java on jdk11 for obvious reason: formatted() is in java.lang.String since jdk15

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8334711 needs maintainer approval

Issue

• JDK-8334711: [TEST_BUG] Compilation failed of MimeFormatsTest/MimeFormatsTest.java (Bug - P4 - Approved)

Reviewers

• Yuri Nesterenko (@yan-too - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2823/head:pull/2823
$ git checkout pull/2823

Update a local copy of the PR:
$ git checkout pull/2823
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2823/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2823

View PR using the GUI difftool:
$ git pr show -t 2823

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2823.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

Hi @sashapepin, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user sashapepin" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

@sashapepin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8334711: [TEST_BUG] Compilation failed of MimeFormatsTest/MimeFormatsTest.java

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 72 new commits pushed to the master branch:

• 7547abf: 8255913: Decrease number of iterations in TestMaxCachedBufferSize
• ee57792: 8259274: Increase timeout duration in sun/nio/ch/TestMaxCachedBufferSize.java
• d668844: 8298873: Update IllegalRecordVersion.java for changes to TLS implementation
• 95c0b97: 8244966: Add .vscode to .hgignore and .gitignore
• de90ed0: 8317228: GC: Make TestXXXHeapSizeFlags use createTestJvm
• 7416eee: 8253207: enable problemlists jcheck's check
• 6c7ee26: 8335803: SunJCE cipher throws NPE for un-extractable RSA keys
• b6cd51a: 8249772: (ch) Improve sun/nio/ch/TestMaxCachedBufferSize.java
• 461e1b2: 8266154: mark hotspot compiler/oracle tests which ignore VM flags
• e6beead: 8266150: mark hotspot compiler/arguments tests which ignore VM flags
• ... and 62 more: https://git.openjdk.org/jdk11u-dev/compare/6547a1687d06f7cb0ece182001babc57915f486b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@yan-too) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[sashapepin]

/covered

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[mlbridge]

Webrevs

• 00: Full (a5c55f79)

[yan-too]

fine with me

[openjdk]

⚠️ @sashapepin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[sashapepin]

/approval JDK-8334711 request Fix the compilation issue

[openjdk]

@sashapepin
JDK-8334711: The approval request has been created successfully.

[sashapepin]

/integrate

[openjdk]

@sashapepin
Your change (at version a5c55f7) is now ready to be sponsored by a Committer.

[yan-too]

/sponsor

[openjdk]

Going to push as commit 8ef8482.
Since your change was applied there have been 72 commits pushed to the master branch:

• 7547abf: 8255913: Decrease number of iterations in TestMaxCachedBufferSize
• ee57792: 8259274: Increase timeout duration in sun/nio/ch/TestMaxCachedBufferSize.java
• d668844: 8298873: Update IllegalRecordVersion.java for changes to TLS implementation
• 95c0b97: 8244966: Add .vscode to .hgignore and .gitignore
• de90ed0: 8317228: GC: Make TestXXXHeapSizeFlags use createTestJvm
• 7416eee: 8253207: enable problemlists jcheck's check
• 6c7ee26: 8335803: SunJCE cipher throws NPE for un-extractable RSA keys
• b6cd51a: 8249772: (ch) Improve sun/nio/ch/TestMaxCachedBufferSize.java
• 461e1b2: 8266154: mark hotspot compiler/oracle tests which ignore VM flags
• e6beead: 8266150: mark hotspot compiler/arguments tests which ignore VM flags
• ... and 62 more: https://git.openjdk.org/jdk11u-dev/compare/6547a1687d06f7cb0ece182001babc57915f486b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@yan-too @sashapepin Pushed as commit 8ef8482.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.