Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8327007: javax/swing/JSpinner/8008657/bug8008657.java fails #2824

Closed

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Jun 27, 2024

Hi all,

This pull request contains a backport of commit b7540df6 from the openjdk/jdk repository.

The commit being backported was authored by Prasanta Sadhukhan on 5 Mar 2024 and was reviewed by Phil Race.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8327007 needs maintainer approval

Issue

  • JDK-8327007: javax/swing/JSpinner/8008657/bug8008657.java fails (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2824/head:pull/2824
$ git checkout pull/2824

Update a local copy of the PR:
$ git checkout pull/2824
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2824/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2824

View PR using the GUI difftool:
$ git pr show -t 2824

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2824.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 27, 2024

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 27, 2024

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8327007: javax/swing/JSpinner/8008657/bug8008657.java fails

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • d88cf4f: 8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns
  • 99435be: 8325876: crashes in docker container tests on Linuxppc64le Power8 machines
  • 2bbdc8c: 8325862: set -XX:+ErrorFileToStderr when executing java in containers for some container related jtreg tests
  • 3c9e960: 8279337: The MToolkit is still referenced in a few places
  • 468d6a7: 8222005: ClassRedefinition crashes with: guarantee(false) failed: OLD and/or OBSOLETE method(s) found
  • 2a5a4d7: 8078725: method adjustments can be done just once for all classes involved into redefinition
  • 3702e90: 8276036: The value of full_count in the message of insufficient codecache is wrong
  • f9d7601: 8328110: Allow simultaneous use of PassFailJFrame with split UI and additional windows
  • db9e313: 8236917: TestInstanceKlassSize.java fails with "The size computed by SA for java.lang.Object does not match"
  • 8578e12: 8303466: C2: failed: malformed control flow. Limit type made precise with MaxL/MinL
  • ... and 5 more: https://git.openjdk.org/jdk11u-dev/compare/569c669891b0011ae9d7fe2593005c8d2ee4e3a6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport b7540df6a4279c63e69d32b9d9834f7a427478d1 8327007: javax/swing/JSpinner/8008657/bug8008657.java fails Jun 27, 2024
@openjdk
Copy link

openjdk bot commented Jun 27, 2024

This backport pull request has now been updated with issue from the original commit.

@mrserb mrserb marked this pull request as ready for review June 27, 2024 20:11
@openjdk
Copy link

openjdk bot commented Jun 27, 2024

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added rfr Pull request is ready for review approval labels Jun 27, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 27, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jul 2, 2024
@mrserb
Copy link
Member Author

mrserb commented Jul 3, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jul 3, 2024

Going to push as commit a30852a.
Since your change was applied there have been 16 commits pushed to the master branch:

  • 7fd48f5: 8260633: [macos] java/awt/dnd/MouseEventAfterStartDragTest/MouseEventAfterStartDragTest.html test failed
  • d88cf4f: 8326140: src/jdk.accessibility/windows/native/libjavaaccessbridge/AccessBridgeJavaEntryPoints.cpp ReleaseStringChars might be missing in early returns
  • 99435be: 8325876: crashes in docker container tests on Linuxppc64le Power8 machines
  • 2bbdc8c: 8325862: set -XX:+ErrorFileToStderr when executing java in containers for some container related jtreg tests
  • 3c9e960: 8279337: The MToolkit is still referenced in a few places
  • 468d6a7: 8222005: ClassRedefinition crashes with: guarantee(false) failed: OLD and/or OBSOLETE method(s) found
  • 2a5a4d7: 8078725: method adjustments can be done just once for all classes involved into redefinition
  • 3702e90: 8276036: The value of full_count in the message of insufficient codecache is wrong
  • f9d7601: 8328110: Allow simultaneous use of PassFailJFrame with split UI and additional windows
  • db9e313: 8236917: TestInstanceKlassSize.java fails with "The size computed by SA for java.lang.Object does not match"
  • ... and 6 more: https://git.openjdk.org/jdk11u-dev/compare/569c669891b0011ae9d7fe2593005c8d2ee4e3a6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 3, 2024
@openjdk openjdk bot closed this Jul 3, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 3, 2024
@openjdk
Copy link

openjdk bot commented Jul 3, 2024

@mrserb Pushed as commit a30852a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant