-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8318039: GHA: Bump macOS and Xcode versions #2835
Conversation
👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into |
@vieiro This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good. Not clean, as 11u skipped JDK-8301097, but that's fine.
I would get this one in first so we at least have Mac OS builds again, even if they are failing. That will allow more people to fix the build issues.
|
/approval request Upgrade GHA to macos-13 as macos-11 is not longer available. Macos builds will still continue to fail until backports for XCode 14/15 are in place, but at least they won't hang. |
/integrate |
/sponsor |
Going to push as commit 82e2866.
Your commit was automatically rebased without conflicts. |
A backport of JDK-8318039 to update GHA to the newest macos/XCode versions.
This in preparation of JDK-8296812 (i.e., all macos builds that are currently hanging now will fail until JDK-8296812 is in place).
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2835/head:pull/2835
$ git checkout pull/2835
Update a local copy of the PR:
$ git checkout pull/2835
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2835/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2835
View PR using the GUI difftool:
$ git pr show -t 2835
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2835.diff
Webrev
Link to Webrev Comment