-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8296812: sprintf is deprecated in Xcode 14 #2836
Conversation
👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout backports/JDK-8296812
git fetch https://git.openjdk.org/jdk11u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
76a5654
to
e5d3f6e
Compare
@vieiro Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
Apologies for the force push (no review comments yet). |
Changes LGTM once src/hotspot/share/adlc/adlc.hpp is resolved |
#2835 should have been delayed until this fix is ready! Now, GHA is broken on MacOS! |
it's been broken for weeks as there were no macos-11 agents available (it just left the CI in a pending state without completion) |
@TheRealMDoerr Yep, the GHA macos-11 builders were deprecated on June the 28th, and all builds have been failing since then. In any case after #2861 (and dependant PRs) the macos builds should be back to normal. |
@vieiro This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@adinn Could you please help review this patch. In particular the changes in |
/reviewers 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems OK to me.
Parent pull requests have been closed without review, so there's no point in continuing just with this PR. |
Backport of JDK-8296812 .
The new GHA build platform (macos-13 / XCode 14) fails because
sprintf
is deprecated. An alternative (os::snprintf_checked
) was introduced in JDK-8296812.This is sadly not a clean backport, as different issues have not been backported to 11 (JDK-8324824, JDK-8303575, JDK-8301050, JDK-8298472, JDK-8298472 to name a few).
The backport required changes to the following files:
And these files were not backported:
While we are at it, this change also replaces
strcat
insrc/hotspot/cpu/aarch64/vm_version_aarch64.cpp
with the newly introducedos::snprintf_checked
to avoid possible buffer overflows.Builds on the new
macos-13
will continue to fail until different issues are backported. The new macos builds report a clash with the standardassert
macro (see [1]) what suggests that JDK-8299254 "Support dealing with standard assert macro" should be backported next.[1]
Progress
Warning
8296812: sprintf is deprecated in Xcode 14
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2836/head:pull/2836
$ git checkout pull/2836
Update a local copy of the PR:
$ git checkout pull/2836
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2836/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2836
View PR using the GUI difftool:
$ git pr show -t 2836
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2836.diff
Webrev
Link to Webrev Comment