8335803: SunJCE cipher throws NPE for un-extractable RSA keys

[alexeybakhtin]

Please review the fix for NPE in RSAPrivateCrtKeyImpl if a custom un-extractable key is provided.

This is a behavioral regression since JDK-8023980

Related JTREG tests passed

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8335803 needs maintainer approval

Issue

• JDK-8335803: SunJCE cipher throws NPE for un-extractable RSA keys (Bug - P3 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2837/head:pull/2837
$ git checkout pull/2837

Update a local copy of the PR:
$ git checkout pull/2837
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2837/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2837

View PR using the GUI difftool:
$ git pr show -t 2837

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2837.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexeybakhtin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8335803: SunJCE cipher throws NPE for un-extractable RSA keys

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 47 new commits pushed to the master branch:

• e74a76a: 8249826: 5 javax/net/ssl/SSLEngine tests use @ignore w/o bug-id
• 3b0f78b: 8266149: mark hotspot compiler/startup tests which ignore VM flags
• 9fe50de: 8255969: Improve java/io/BufferedInputStream/LargeCopyWithMark.java using jtreg tags
• 1943345: 8275851: Deproblemlist open/test/jdk/javax/swing/JComponent/6683775/bug6683775.java
• 92df183: 8266153: mark hotspot compiler/onSpinWait tests which ignore VM flags
• 54949eb: 8332424: Update IANA Language Subtag Registry to Version 2024-05-16
• d51bb43: 8327631: Update IANA Language Subtag Registry to Version 2024-03-07
• b423f01: 8299058: AssertionError in sun.net.httpserver.ServerImpl when connection is idle
• e655a2f: 8332898: failure_handler: log directory of commands
• bc4a525: 8315422: getSoTimeout() would be in try block in SSLSocketImpl
• ... and 37 more: https://git.openjdk.org/jdk11u-dev/compare/cdfb4e7d6cd50232ee485e2e4038c7e34394311a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (7f4eb9f4)

[openjdk]

⚠️ @alexeybakhtin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[alexeybakhtin]

MacOS CI failures are not related to the changes

[alexeybakhtin]

/integrate

[openjdk]

Going to push as commit 6c7ee26.
Since your change was applied there have been 51 commits pushed to the master branch:

• b6cd51a: 8249772: (ch) Improve sun/nio/ch/TestMaxCachedBufferSize.java
• 461e1b2: 8266154: mark hotspot compiler/oracle tests which ignore VM flags
• e6beead: 8266150: mark hotspot compiler/arguments tests which ignore VM flags
• a049bf1: 8334418: Update IANA Language Subtag Registry to Version 2024-06-14
• e74a76a: 8249826: 5 javax/net/ssl/SSLEngine tests use @ignore w/o bug-id
• 3b0f78b: 8266149: mark hotspot compiler/startup tests which ignore VM flags
• 9fe50de: 8255969: Improve java/io/BufferedInputStream/LargeCopyWithMark.java using jtreg tags
• 1943345: 8275851: Deproblemlist open/test/jdk/javax/swing/JComponent/6683775/bug6683775.java
• 92df183: 8266153: mark hotspot compiler/onSpinWait tests which ignore VM flags
• 54949eb: 8332424: Update IANA Language Subtag Registry to Version 2024-05-16
• ... and 41 more: https://git.openjdk.org/jdk11u-dev/compare/cdfb4e7d6cd50232ee485e2e4038c7e34394311a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexeybakhtin Pushed as commit 6c7ee26.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.