8335801: [11u] Backport of 8210988 to 11u removes gcc warnings

[gnu-andrew]

The backport of 8210988 contained a number of issues, the most serious of which is it completely removed warnings from gcc builds by changing WARNING_CFLAGS_JDK and WARNING_CFLAGS_JVM, but not defining WARNINGS_ENABLE_ALL, WARNINGS_ENABLE_ADDITIONAL_JVM and DISABLED_WARNINGS.

The other more minor issues are the silent inclusion of -Wreorder to clang builds (should be a backport of JDK-8208672) and -xc99=%none (reverting JDK-8215296), because new lines were used as is without comparing differences in what was being replaced.

All three of these changes show up clearly when comparing the 11u & 12u changesets, and are corrected by this patch.

I can also confirm this has the desired effect with warnings as my local build on GCC 13 now fails again, whereas it was passing before (we need some backports there to make that work)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8335801 needs maintainer approval

Issue

• JDK-8335801: [11u] Backport of 8210988 to 11u removes gcc warnings (Bug - P4 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2838/head:pull/2838
$ git checkout pull/2838

Update a local copy of the PR:
$ git checkout pull/2838
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2838/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2838

View PR using the GUI difftool:
$ git pr show -t 2838

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2838.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@gnu-andrew This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8335801: [11u] Backport of 8210988 to 11u removes gcc warnings

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 01: Full - Incremental (4e9ee141)
• 00: Full (b4fadd62)

[bridgekeeper]

@gnu-andrew This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[gnu-andrew]

Keep this open. Still waiting on a review.

[openjdk]

⚠️ @gnu-andrew This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[gnu-andrew]

Thanks Paul!

/approval request Resolves a regression introduced in 11.0.24 by a bad backport of 8210988 which removed all gcc warning flags, along with a number of other minor issues. Patch has been reviewed by Paul Hohensee.

[openjdk]

@gnu-andrew
8335801: The approval request has been created successfully.

[bridgekeeper]

@gnu-andrew This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[jerboaa]

It would be good to first wait on #2937 and merge that in so as to have fixed MacOX X GHA checks.

[gnu-andrew]

It would be good to first wait on #2937 and merge that in so as to have fixed MacOX X GHA checks.

Ok, but you do realise this is fixing a regression, not something new? This should really have been fixed in 11.0.25. We are currently building without any of the usual warnings turned on.

[bridgekeeper]

@gnu-andrew This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[gnu-andrew]

Merged with latest jdk11u-dev and tests passed. Merging.
/integrate

[openjdk]

Going to push as commit c99638d.
Since your change was applied there has been 1 commit pushed to the master branch:

• 513a67a: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test

Your commit was automatically rebased without conflicts.

[openjdk]

@gnu-andrew Pushed as commit c99638d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.