Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8251570: JDK-8215624 causes assert(worker_id < _n_workers) failed: Invalid worker_id #284

Closed
wants to merge 3 commits into from
Closed

8251570: JDK-8215624 causes assert(worker_id < _n_workers) failed: Invalid worker_id #284

wants to merge 3 commits into from

Conversation

buddyliao
Copy link
Contributor

@buddyliao buddyliao commented Aug 24, 2021

This patch is backport based on #127

I have built it on linux x86_64 and run test-tier1 successfully


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8251570: JDK-8215624 causes assert(worker_id < _n_workers) failed: Invalid worker_id

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/284/head:pull/284
$ git checkout pull/284

Update a local copy of the PR:
$ git checkout pull/284
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/284/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 284

View PR using the GUI difftool:
$ git pr show -t 284

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/284.diff

buddyliao added 3 commits July 13, 2021 17:19
    8215624: Add parallel heap iteration for jmap histo
    8253763: ParallelObjectIterator should have virtual destructor
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 24, 2021

👋 Welcome back buddyliao! A progress list of the required criteria for merging this PR into pr/127 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2631422bc55c8a411e170c5bf737a1882a61d2f5 8251570: JDK-8215624 causes assert(worker_id < _n_workers) failed: Invalid worker_id Aug 24, 2021
@openjdk
Copy link

openjdk bot commented Aug 24, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Aug 24, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 24, 2021

Webrevs

Copy link
Contributor

@schmelter-sap schmelter-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. Thanks.

@buddyliao
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 8, 2021

@buddyliao This PR has not yet been marked as ready for integration.

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/127 to master September 8, 2021 05:13
@openjdk-notifier
Copy link

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout parallel_heap_iter
git fetch https://git.openjdk.java.net/jdk11u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

openjdk bot commented Sep 8, 2021

@buddyliao This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8251570: JDK-8215624 causes assert(worker_id < _n_workers) failed: Invalid worker_id

Reviewed-by: rschmelter, clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 60 new commits pushed to the master branch:

  • 085dbe3: 8215624: Add parallel heap iteration for jmap –histo
  • 2de01c1: 8269993: [Test]: java/net/httpclient/DigestEchoClientSSL.java contains redundant @run tags
  • 47e4bc9: 8269984: [macos] JTabbedPane title looks like disabled
  • 569688f: 8272316: Wrong Boot JDK help message in 11
  • 1645dbe: 8262731: [macOS] Exception from "Printable.print" is swallowed during "PrinterJob.print"
  • 9efd897: 8261236: C2: ClhsdbJstackXcompStress test fails when StressGCM is enabled
  • 2908bbd: 8270216: [macOS] Update named used for Java run loop mode
  • ea1a1d8: 8251377: [macos11] JTabbedPane selected tab text is barely legible
  • 9a5ba0b: 7179006: [macosx] Print-to-file doesn't work: printing to the default printer instead
  • d41b37f: 8263362: Avoid division by 0 in java/awt/font/TextJustifier.java justify
  • ... and 50 more: https://git.openjdk.java.net/jdk11u-dev/compare/5ce46d9679fd9c9010bcfe55fd723a0f068b3333...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealCLanger) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 8, 2021
@RealCLanger
Copy link
Contributor

@buddyliao, please type /integrate again and I can sponsor this.
PS: For the future: Before integrating a PR, please make sure it has the appropriate jdk11u-fix-yes label in JBS, even though it was already reviewed.

@buddyliao
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 8, 2021
@openjdk
Copy link

openjdk bot commented Sep 8, 2021

@buddyliao
Your change (at version d04253d) is now ready to be sponsored by a Committer.

@buddyliao
Copy link
Contributor Author

@buddyliao, please type /integrate again and I can sponsor this.
PS: For the future: Before integrating a PR, please make sure it has the appropriate jdk11u-fix-yes label in JBS, even though it was already reviewed.

Thank you , I will remember this in the feature.

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 8, 2021

Going to push as commit 1d1e4ce.
Since your change was applied there have been 60 commits pushed to the master branch:

  • 085dbe3: 8215624: Add parallel heap iteration for jmap –histo
  • 2de01c1: 8269993: [Test]: java/net/httpclient/DigestEchoClientSSL.java contains redundant @run tags
  • 47e4bc9: 8269984: [macos] JTabbedPane title looks like disabled
  • 569688f: 8272316: Wrong Boot JDK help message in 11
  • 1645dbe: 8262731: [macOS] Exception from "Printable.print" is swallowed during "PrinterJob.print"
  • 9efd897: 8261236: C2: ClhsdbJstackXcompStress test fails when StressGCM is enabled
  • 2908bbd: 8270216: [macOS] Update named used for Java run loop mode
  • ea1a1d8: 8251377: [macos11] JTabbedPane selected tab text is barely legible
  • 9a5ba0b: 7179006: [macosx] Print-to-file doesn't work: printing to the default printer instead
  • d41b37f: 8263362: Avoid division by 0 in java/awt/font/TextJustifier.java justify
  • ... and 50 more: https://git.openjdk.java.net/jdk11u-dev/compare/5ce46d9679fd9c9010bcfe55fd723a0f068b3333...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 8, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 8, 2021
@openjdk
Copy link

openjdk bot commented Sep 8, 2021

@RealCLanger @buddyliao Pushed as commit 1d1e4ce.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants