-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8251570: JDK-8215624 causes assert(worker_id < _n_workers) failed: Invalid worker_id #284
8251570: JDK-8215624 causes assert(worker_id < _n_workers) failed: Invalid worker_id #284
Conversation
8215624: Add parallel heap iteration for jmap histo 8253763: ParallelObjectIterator should have virtual destructor
👋 Welcome back buddyliao! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me. Thanks.
/integrate |
@buddyliao This PR has not yet been marked as ready for integration. |
The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout parallel_heap_iter
git fetch https://git.openjdk.java.net/jdk11u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
@buddyliao This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 60 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealCLanger) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
@buddyliao, please type /integrate again and I can sponsor this. |
/integrate |
@buddyliao |
Thank you , I will remember this in the feature. |
/sponsor |
Going to push as commit 1d1e4ce.
Your commit was automatically rebased without conflicts. |
@RealCLanger @buddyliao Pushed as commit 1d1e4ce. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This patch is backport based on #127
I have built it on linux x86_64 and run test-tier1 successfully
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/284/head:pull/284
$ git checkout pull/284
Update a local copy of the PR:
$ git checkout pull/284
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/284/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 284
View PR using the GUI difftool:
$ git pr show -t 284
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/284.diff