Skip to content

8309934: Update GitHub Actions to use JDK 17 for building jtreg #2845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

gdams
Copy link
Member

@gdams gdams commented Jul 9, 2024

Makes sense to be consistent with newer versions, applies cleanly


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8309934 needs maintainer approval

Issue

  • JDK-8309934: Update GitHub Actions to use JDK 17 for building jtreg (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2845/head:pull/2845
$ git checkout pull/2845

Update a local copy of the PR:
$ git checkout pull/2845
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2845/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2845

View PR using the GUI difftool:
$ git pr show -t 2845

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2845.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 9, 2024

👋 Welcome back gdams! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 9, 2024

@gdams This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8309934: Update GitHub Actions to use JDK 17 for building jtreg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 9bf121d: 8255898: Test java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.java fails on Mac OS
  • c7b9769: 8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to automatic main test
  • 236ce17: 8328238: Convert few closed manual applet tests to main
  • 4c626c8: 8316306: Open source and convert manual Swing test
  • b05f58e: 8334653: ISO 4217 Amendment 177 Update
  • 5375248: 8332524: Instead of printing "TLSv1.3," it is showing "TLS13"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 8aad881e803fddc26f45270f779ff0c0e5a095d8 8309934: Update GitHub Actions to use JDK 17 for building jtreg Jul 9, 2024
@openjdk
Copy link

openjdk bot commented Jul 9, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 9, 2024

⚠️ @gdams This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 9, 2024
@gdams
Copy link
Member Author

gdams commented Jul 9, 2024

/approval request backport applies cleanly, CI only, low risk. Makes sense to backport to 11u to be consistent with newer versions which use the same version of JTREG

@openjdk
Copy link

openjdk bot commented Jul 9, 2024

@gdams
8309934: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jul 9, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 9, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jul 12, 2024
@gdams
Copy link
Member Author

gdams commented Jul 12, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jul 12, 2024

Going to push as commit 32d2713.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 9bf121d: 8255898: Test java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.java fails on Mac OS
  • c7b9769: 8328158: Convert java/awt/Choice/NonFocusablePopupMenuTest to automatic main test
  • 236ce17: 8328238: Convert few closed manual applet tests to main
  • 4c626c8: 8316306: Open source and convert manual Swing test
  • b05f58e: 8334653: ISO 4217 Amendment 177 Update
  • 5375248: 8332524: Instead of printing "TLSv1.3," it is showing "TLS13"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 12, 2024
@openjdk openjdk bot closed this Jul 12, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 12, 2024
@openjdk
Copy link

openjdk bot commented Jul 12, 2024

@gdams Pushed as commit 32d2713.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant