Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8299378: sprintf is deprecated in Xcode 14 #2848

Closed
wants to merge 1 commit into from

Conversation

vieiro
Copy link
Contributor

@vieiro vieiro commented Jul 10, 2024

Clean backport of JDK-8299378, as applied to 17.

This replaces the deprecated sprintf with os::snprintf_checked in more places, for the build to progress in the new macos-13 GHA.

The build will still fail until all remaining backports replace sprintfin all places of the codebase.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8299378 needs maintainer approval

Integration blocker

 ⚠️ Dependency #2846 must be integrated first

Issue

  • JDK-8299378: sprintf is deprecated in Xcode 14 (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2848/head:pull/2848
$ git checkout pull/2848

Update a local copy of the PR:
$ git checkout pull/2848
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2848/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2848

View PR using the GUI difftool:
$ git pr show -t 2848

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2848.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 10, 2024

👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into pr/2846 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 10, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 8d974eacf19b206978910f50a09bf68767ab9765 8299378: sprintf is deprecated in Xcode 14 Jul 10, 2024
@openjdk
Copy link

openjdk bot commented Jul 10, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jul 10, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 10, 2024

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 7, 2024

@vieiro This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 4, 2024

@vieiro This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Sep 4, 2024
@vieiro vieiro deleted the backports/JDK-8299378 branch September 5, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant