8299378: sprintf is deprecated in Xcode 14 #2848
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean backport of JDK-8299378, as applied to 17.
This replaces the deprecated
sprintf
withos::snprintf_checked
in more places, for the build to progress in the new macos-13 GHA.The build will still fail until all remaining backports replace
sprintf
in all places of the codebase.Progress
Integration blocker
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2848/head:pull/2848
$ git checkout pull/2848
Update a local copy of the PR:
$ git checkout pull/2848
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2848/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2848
View PR using the GUI difftool:
$ git pr show -t 2848
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2848.diff
Webrev
Link to Webrev Comment