-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all #2856
Conversation
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
@sendaoYan This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
/approval request This testcase also intermittent fails with jdk11u, so I think it's necessary backport to jdk11u-dev. It's not clean backport beause jdk11u-dev has different context to jdk17u-dev. |
@sendaoYan |
The GHA report |
Thanks for the approved. |
Thanks for the approved and review. |
@sendaoYan |
/sponsor |
Going to push as commit c87a410.
Your commit was automatically rebased without conflicts. |
@phohensee @sendaoYan Pushed as commit c87a410. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Thanks for the sponsor. |
Hi all,
This pull request contains a backport of commit 61e2dba5 from the openjdk/jdk17u-dev repository.
The commit being backported was authored by SendaoYan on 12 Jul 2024 and was reviewed by Paul Hohensee.
It's backport from jdk17u-dev, this testcase also intermittent fails with jdk11u. So I think it's necessary backport to jdk11u-dev. It's not clean backport beause jdk11u-dev has different context to jdk17u-dev.
Thanks!
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2856/head:pull/2856
$ git checkout pull/2856
Update a local copy of the PR:
$ git checkout pull/2856
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2856/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2856
View PR using the GUI difftool:
$ git pr show -t 2856
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2856.diff
Webrev
Link to Webrev Comment