Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8199931: java/net/MulticastSocket/UnreferencedMulticastSockets.java fails with "incorrect data received" #286

Closed

Conversation

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Aug 24, 2021

Hi all,

this pull request contains a backport of JDK-8199931 from the openjdk/jdk repository.

The commit being backported was authored by Chris Yin on 21 Sep 2018 and was reviewed by Chris Hegarty.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8199931: java/net/MulticastSocket/UnreferencedMulticastSockets.java fails with "incorrect data received"

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/286/head:pull/286
$ git checkout pull/286

Update a local copy of the PR:
$ git checkout pull/286
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/286/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 286

View PR using the GUI difftool:
$ git pr show -t 286

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/286.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 24, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f367eb89657e69989c15463fd4195d6869c132f5 8199931: java/net/MulticastSocket/UnreferencedMulticastSockets.java fails with "incorrect data received" Aug 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 24, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 24, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8199931: java/net/MulticastSocket/UnreferencedMulticastSockets.java fails with "incorrect data received"

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 24, 2021

Webrevs

@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Aug 27, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 27, 2021

Going to push as commit 069b4cc.
Since your change was applied there have been 11 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 27, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 27, 2021

@RealCLanger Pushed as commit 069b4cc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant