-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8317228: GC: Make TestXXXHeapSizeFlags use createTestJvm #2864
Conversation
👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into |
@luchenlin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 41 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
7ffd301
to
bfa4783
Compare
@luchenlin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
cb0e8fc
to
067e574
Compare
@luchenlin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
|
/integrate |
Going to push as commit de90ed0.
Your commit was automatically rebased without conflicts. |
@luchenlin Pushed as commit de90ed0. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
I backport this for parity with 11.0.25-oracle.
test/hotspot/jtreg/gc/arguments/TestG1HeapSizeFlags.java
test/hotspot/jtreg/gc/arguments/TestParallelHeapSizeFlags.java
test/hotspot/jtreg/gc/arguments/TestSerialHeapSizeFlags.java
these three classes already contain key "gc", I merged the key "gc" and "flag-sensitive"
this class test/jtreg-ext/requires/VMProps.java uses String.splitWithDelimiters, but it is not support in jdk11, I changed it in my own way.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2864/head:pull/2864
$ git checkout pull/2864
Update a local copy of the PR:
$ git checkout pull/2864
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2864/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2864
View PR using the GUI difftool:
$ git pr show -t 2864
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2864.diff
Webrev
Link to Webrev Comment