Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317228: GC: Make TestXXXHeapSizeFlags use createTestJvm #2864

Closed
wants to merge 3 commits into from

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Jul 18, 2024

I backport this for parity with 11.0.25-oracle.

test/hotspot/jtreg/gc/arguments/TestG1HeapSizeFlags.java
test/hotspot/jtreg/gc/arguments/TestParallelHeapSizeFlags.java
test/hotspot/jtreg/gc/arguments/TestSerialHeapSizeFlags.java

these three classes already contain key "gc", I merged the key "gc" and "flag-sensitive"

this class test/jtreg-ext/requires/VMProps.java uses String.splitWithDelimiters, but it is not support in jdk11, I changed it in my own way.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8317228 needs maintainer approval

Issue

  • JDK-8317228: GC: Make TestXXXHeapSizeFlags use createTestJvm (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2864/head:pull/2864
$ git checkout pull/2864

Update a local copy of the PR:
$ git checkout pull/2864
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2864/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2864

View PR using the GUI difftool:
$ git pr show -t 2864

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2864.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 18, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 18, 2024

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8317228: GC: Make TestXXXHeapSizeFlags use createTestJvm

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 41 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 7ca0ae94159ac0fd2df23ee1a1e8cf626ce31048 8317228: GC: Make TestXXXHeapSizeFlags use createTestJvm Jul 18, 2024
@openjdk
Copy link

openjdk bot commented Jul 18, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 18, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 18, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 23, 2024

@luchenlin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk
Copy link

openjdk bot commented Jul 23, 2024

@luchenlin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk
Copy link

openjdk bot commented Jul 25, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jul 26, 2024
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 30, 2024

Going to push as commit de90ed0.
Since your change was applied there have been 41 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 30, 2024
@openjdk openjdk bot closed this Jul 30, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 30, 2024
@openjdk
Copy link

openjdk bot commented Jul 30, 2024

@luchenlin Pushed as commit de90ed0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants