Skip to content

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Jul 29, 2024

Hi all,
This is backport of JDK-8244966, to add .vscode to .gitignore.
It's not clean because in jdk11u-dev the .hgignore has been deleted by JDK-8254178.
Trivial fix, no risk.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8244966 needs maintainer approval

Issue

  • JDK-8244966: Add .vscode to .hgignore and .gitignore (Enhancement - P5 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2883/head:pull/2883
$ git checkout pull/2883

Update a local copy of the PR:
$ git checkout pull/2883
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2883/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2883

View PR using the GUI difftool:
$ git pr show -t 2883

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2883.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 29, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 29, 2024

@sendaoYan This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8244966: Add .vscode to .hgignore and .gitignore

Add .vscode to .hgignore and .gitignore

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • de90ed0: 8317228: GC: Make TestXXXHeapSizeFlags use createTestJvm
  • 7416eee: 8253207: enable problemlists jcheck's check

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport d3e0c4ce9c22e69e6eac17257a02d5e796b84bac 8244966: Add .vscode to .hgignore and .gitignore Jul 29, 2024
@openjdk
Copy link

openjdk bot commented Jul 29, 2024

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Jul 29, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 29, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 29, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@sendaoYan
Copy link
Member Author

Thanks for the review.

@sendaoYan
Copy link
Member Author

sendaoYan commented Jul 30, 2024

The GHA report macos-aarch64 and macos-x64 compile error 'sprintf' is deprecated, I think it's unrelated to this PR.

@sendaoYan
Copy link
Member Author

/approval request Backport JDK-8244966 to add .vscode to .gitignore. Trivial fix, no risk.

@openjdk
Copy link

openjdk bot commented Jul 30, 2024

@sendaoYan
8244966: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jul 30, 2024
@gdams
Copy link
Member

gdams commented Jul 30, 2024

The GHA report macos-aarch64 and macos-x64 compile errro 'sprintf' is deprecated, I think it's unrelated to this PR.

Just confirming that this is unrelated and being fixed elsewhere

@sendaoYan
Copy link
Member Author

Thanks for the approved.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 30, 2024
@openjdk
Copy link

openjdk bot commented Jul 30, 2024

@sendaoYan
Your change (at version 0c49f0b) is now ready to be sponsored by a Committer.

@gdams
Copy link
Member

gdams commented Jul 30, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 30, 2024

Going to push as commit 95c0b97.
Since your change was applied there have been 2 commits pushed to the master branch:

  • de90ed0: 8317228: GC: Make TestXXXHeapSizeFlags use createTestJvm
  • 7416eee: 8253207: enable problemlists jcheck's check

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 30, 2024
@openjdk openjdk bot closed this Jul 30, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 30, 2024
@openjdk
Copy link

openjdk bot commented Jul 30, 2024

@gdams @sendaoYan Pushed as commit 95c0b97.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan sendaoYan deleted the jbs8244966 branch July 30, 2024 15:06
@sendaoYan
Copy link
Member Author

Thanks for the sponsor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants