-
Notifications
You must be signed in to change notification settings - Fork 253
8244966: Add .vscode to .hgignore and .gitignore #2883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
|
@sendaoYan This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue and summary from the original commit. |
|
|
|
Thanks for the review. |
|
The GHA report macos-aarch64 and macos-x64 compile error |
|
/approval request Backport JDK-8244966 to add .vscode to .gitignore. Trivial fix, no risk. |
|
@sendaoYan |
Just confirming that this is unrelated and being fixed elsewhere |
|
Thanks for the approved. |
|
@sendaoYan |
|
/sponsor |
|
@gdams @sendaoYan Pushed as commit 95c0b97. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
|
Thanks for the sponsor. |
Hi all,
This is backport of JDK-8244966, to add
.vscodeto.gitignore.It's not clean because in jdk11u-dev the
.hgignorehas been deleted by JDK-8254178.Trivial fix, no risk.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2883/head:pull/2883$ git checkout pull/2883Update a local copy of the PR:
$ git checkout pull/2883$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2883/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2883View PR using the GUI difftool:
$ git pr show -t 2883Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2883.diff
Webrev
Link to Webrev Comment