Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298873: Update IllegalRecordVersion.java for changes to TLS implementation #2887

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Jul 30, 2024

I backport this with 17 backport, includes follow-up JDK-8301189


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8298873 needs maintainer approval
  • JDK-8301189 needs maintainer approval

Issues

  • JDK-8298873: Update IllegalRecordVersion.java for changes to TLS implementation (Bug - P4 - Approved)
  • JDK-8301189: validate-source fails after JDK-8298873 (Bug - P1 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2887/head:pull/2887
$ git checkout pull/2887

Update a local copy of the PR:
$ git checkout pull/2887
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2887/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2887

View PR using the GUI difftool:
$ git pr show -t 2887

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2887.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 30, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 30, 2024

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8298873: Update IllegalRecordVersion.java for changes to TLS implementation
8301189: validate-source fails after JDK-8298873

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 95c0b97: 8244966: Add .vscode to .hgignore and .gitignore

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 28adafcb524a043eca0fc6e7f9a1bb2a5490d723 8298873: Update IllegalRecordVersion.java for changes to TLS implementation Jul 30, 2024
@openjdk
Copy link

openjdk bot commented Jul 30, 2024

This backport pull request has now been updated with issues from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 30, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 30, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 30, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jul 31, 2024
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 1, 2024

Going to push as commit d668844.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 95c0b97: 8244966: Add .vscode to .hgignore and .gitignore

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 1, 2024
@openjdk openjdk bot closed this Aug 1, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 1, 2024
@openjdk
Copy link

openjdk bot commented Aug 1, 2024

@luchenlin Pushed as commit d668844.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant