Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion #2889

Closed
wants to merge 1 commit into from

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Aug 1, 2024

I backport this for parity with 11.0.25-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8336301 needs maintainer approval

Issue

  • JDK-8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2889/head:pull/2889
$ git checkout pull/2889

Update a local copy of the PR:
$ git checkout pull/2889
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2889/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2889

View PR using the GUI difftool:
$ git pr show -t 2889

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2889.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 1, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 1, 2024

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 1daafdd: 8317343: GC: Make TestHeapFreeRatio use createTestJvm
  • 8ef8482: 8334711: [TEST_BUG] Compilation failed of MimeFormatsTest/MimeFormatsTest.java
  • 7547abf: 8255913: Decrease number of iterations in TestMaxCachedBufferSize
  • ee57792: 8259274: Increase timeout duration in sun/nio/ch/TestMaxCachedBufferSize.java
  • d668844: 8298873: Update IllegalRecordVersion.java for changes to TLS implementation

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport ae9f318fc35eeab497e546ebab9faed6ec774ec5 8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion Aug 1, 2024
@openjdk
Copy link

openjdk bot commented Aug 1, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 1, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 1, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 1, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Aug 2, 2024
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 6, 2024

Going to push as commit c5d2cc1.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 7d34693: 8317358: G1: Make TestMaxNewSize use createTestJvm
  • 1daafdd: 8317343: GC: Make TestHeapFreeRatio use createTestJvm
  • 8ef8482: 8334711: [TEST_BUG] Compilation failed of MimeFormatsTest/MimeFormatsTest.java
  • 7547abf: 8255913: Decrease number of iterations in TestMaxCachedBufferSize
  • ee57792: 8259274: Increase timeout duration in sun/nio/ch/TestMaxCachedBufferSize.java
  • d668844: 8298873: Update IllegalRecordVersion.java for changes to TLS implementation

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 6, 2024
@openjdk openjdk bot closed this Aug 6, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 6, 2024
@openjdk
Copy link

openjdk bot commented Aug 6, 2024

@luchenlin Pushed as commit c5d2cc1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant