8325022: Incorrect error message on client authentication

[amosshi]

Backport of JDK-8325022

Testing

• Local:
  • Build passed on MacOS 14.6.1 on Apple M1 Max
  • No applicable test case
• Pipeline:
  • Linux and Windows - passed
  • Mac - adlparse.cpp:214:11: error: 'sprintf' is deprecated - this message is not caused by current PR
    • src/hotspot/share/adlc/archDesc.cpp:813:5: error: 'sprintf' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead.
    • The line archDesc.cpp:813 was introduced 13 years ago via 07d9df5
    • See https://github.com/openjdk/jdk11u-dev/blame/master/src/hotspot/share/adlc/archDesc.cpp#L813C5-L813C46
• Testing Machine: SAP nightlies Passed on 2024-08-16 (No side effect caused by this PR found)

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8325022 needs maintainer approval

Issue

• JDK-8325022: Incorrect error message on client authentication (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2899/head:pull/2899
$ git checkout pull/2899

Update a local copy of the PR:
$ git checkout pull/2899
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2899/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2899

View PR using the GUI difftool:
$ git pr show -t 2899

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2899.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@amosshi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8325022: Incorrect error message on client authentication

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 828d645: 8314614: jdk/jshell/ImportTest.java failed with "InternalError: Failed remote listen"
• cd4ae8c: 8316973: GC: Make TestDisableDefaultGC use createTestJvm
• cd9e6cb: 8334166: Enable binary check
• 3caf501: 8336928: GHA: Bundle artifacts removal broken
• d8632ed: 8269616: serviceability/dcmd/framework/VMVersionTest.java fails with Address already in use error
• 30f532b: 7156347: javax/swing/JList/6462008/bug6462008.java fails
• fa64c0e: 8316285: Opensource JButton manual tests
• 3f2d6f0: 8332113: Update nsk.share.Log to be always verbose
• 3c43b2f: 8315965: Open source various AWT applet tests
• f7217d7: 8286601: Mac Aarch: Excessive warnings to be ignored for build jdk
• ... and 1 more: https://git.openjdk.org/jdk11u-dev/compare/648e8f01896b46aa338b1607de70dc1f17706008...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (b2692ba0)

[amosshi]

/approval request "Backporting as JDK-8330278 dependency. Clean backport. Test passes and SAP nightlies pass on 2024-08-16,17”

[openjdk]

@amosshi
8325022: The approval request has been created successfully.

[amosshi]

/integrate

[openjdk]

Going to push as commit c67fe36.
Since your change was applied there have been 14 commits pushed to the master branch:

• 3df1852: 8210338: Better output for GenerationTests.java
• 9ba9dd2: 8224081: SOCKS v4 tests require IPv4
• d3ce405: 8206440: Remove javac -source/-target 6 from jdk regression tests
• 828d645: 8314614: jdk/jshell/ImportTest.java failed with "InternalError: Failed remote listen"
• cd4ae8c: 8316973: GC: Make TestDisableDefaultGC use createTestJvm
• cd9e6cb: 8334166: Enable binary check
• 3caf501: 8336928: GHA: Bundle artifacts removal broken
• d8632ed: 8269616: serviceability/dcmd/framework/VMVersionTest.java fails with Address already in use error
• 30f532b: 7156347: javax/swing/JList/6462008/bug6462008.java fails
• fa64c0e: 8316285: Opensource JButton manual tests
• ... and 4 more: https://git.openjdk.org/jdk11u-dev/compare/648e8f01896b46aa338b1607de70dc1f17706008...master

Your commit was automatically rebased without conflicts.

[openjdk]

@amosshi Pushed as commit c67fe36.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.