Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8251930: AArch64: Native types mismatch in hotspot #290

Closed
wants to merge 1 commit into from

Conversation

@VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Aug 24, 2021

Applies almost clean, one context code difference and one whitespace issue


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8251930: AArch64: Native types mismatch in hotspot

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/290/head:pull/290
$ git checkout pull/290

Update a local copy of the PR:
$ git checkout pull/290
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/290/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 290

View PR using the GUI difftool:
$ git pr show -t 290

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/290.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 24, 2021

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport f1e07806686a837f744e279b6b11394be88c0818 8251930: AArch64: Native types mismatch in hotspot Aug 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 24, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 24, 2021

Webrevs

Loading

@VladimirKempik
Copy link
Author

@VladimirKempik VladimirKempik commented Sep 5, 2021

The failure in windows x64 is false positive and not related to this PR, this PR only changes code in hotspot/cpu/aarch64 subfolder.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 8, 2021

@VladimirKempik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8251930: AArch64: Native types mismatch in hotspot

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

  • c88867c: 8248899: security/infra/java/security/cert/CertPathValidator/certification/QuoVadisCA.java fails, Certificate has been revoked
  • 1d1e4ce: 8251570: JDK-8215624 causes assert(worker_id < _n_workers) failed: Invalid worker_id
  • 085dbe3: 8215624: Add parallel heap iteration for jmap –histo
  • 2de01c1: 8269993: [Test]: java/net/httpclient/DigestEchoClientSSL.java contains redundant @run tags
  • 47e4bc9: 8269984: [macos] JTabbedPane title looks like disabled
  • 569688f: 8272316: Wrong Boot JDK help message in 11
  • 1645dbe: 8262731: [macOS] Exception from "Printable.print" is swallowed during "PrinterJob.print"
  • 9efd897: 8261236: C2: ClhsdbJstackXcompStress test fails when StressGCM is enabled
  • 2908bbd: 8270216: [macOS] Update named used for Java run loop mode
  • ea1a1d8: 8251377: [macos11] JTabbedPane selected tab text is barely legible
  • ... and 25 more: https://git.openjdk.java.net/jdk11u-dev/compare/5a539dbc161494c6e4d4a206cea82d1457ac1751...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 8, 2021
@VladimirKempik
Copy link
Author

@VladimirKempik VladimirKempik commented Sep 9, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 9, 2021

Going to push as commit 8da3a00.
Since your change was applied there have been 37 commits pushed to the master branch:

  • cf95c4c: 8206085: Refactor langtools/tools/javac/versions/Versions.java
  • ae0d088: 8270317: Large Allocation in CipherSuite
  • c88867c: 8248899: security/infra/java/security/cert/CertPathValidator/certification/QuoVadisCA.java fails, Certificate has been revoked
  • 1d1e4ce: 8251570: JDK-8215624 causes assert(worker_id < _n_workers) failed: Invalid worker_id
  • 085dbe3: 8215624: Add parallel heap iteration for jmap –histo
  • 2de01c1: 8269993: [Test]: java/net/httpclient/DigestEchoClientSSL.java contains redundant @run tags
  • 47e4bc9: 8269984: [macos] JTabbedPane title looks like disabled
  • 569688f: 8272316: Wrong Boot JDK help message in 11
  • 1645dbe: 8262731: [macOS] Exception from "Printable.print" is swallowed during "PrinterJob.print"
  • 9efd897: 8261236: C2: ClhsdbJstackXcompStress test fails when StressGCM is enabled
  • ... and 27 more: https://git.openjdk.java.net/jdk11u-dev/compare/5a539dbc161494c6e4d4a206cea82d1457ac1751...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Sep 9, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 9, 2021

@VladimirKempik Pushed as commit 8da3a00.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@VladimirKempik VladimirKempik deleted the JDK-8251930 branch Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants