Skip to content

8220673: Add test library support for determining platform IP support #2910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Aug 15, 2024

I backport this for parity with 11.0.25-oracle.
these tests are not clean, but all added code is clean
test/jdk/java/net/NetworkInterface/Test.java
test/jdk/java/net/Socket/CloseAvailable.java
test/jdk/java/net/Socket/HttpProxy.java
test/jdk/java/net/Socket/SetSoLinger.java
test/jdk/java/nio/channels/DatagramChannel/Disconnect.java

this class is not exist, ignore, other classes are clean
test/jdk/java/nio/channels/etc/PrintSupportedOptions.java

As https://bugs.openjdk.org/browse/JDK-8239355 is already backported, f4288be
so not modify the test/lib/jdk/test/lib/net/IPSupport.java
it missed to backported to modify the test/jdk/java/net/IPSupport/MinimumPermissions.policy
so here edit it.

also add backport for https://bugs.openjdk.org/browse/JDK-8223652
otherwise other tests will fail due to the throwSkippedExceptionIfNonOperational() change


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8220673 needs maintainer approval
  • JDK-8223652 needs maintainer approval
  • Commit message must refer to an issue

Issues

  • JDK-8220673: Add test library support for determining platform IP support (Sub-task - P3)
  • JDK-8223652: Rename IPSupport.skipIfCurrentConfigurationIsInvalid() (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2910/head:pull/2910
$ git checkout pull/2910

Update a local copy of the PR:
$ git checkout pull/2910
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2910/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2910

View PR using the GUI difftool:
$ git pr show -t 2910

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2910.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 15, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 15, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 0bb6328356f0f0789d1e10d32f6b66981fd68e6b 8220673: Add test library support for determining platform IP support Aug 15, 2024
@openjdk
Copy link

openjdk bot commented Aug 15, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Aug 15, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 15, 2024

Webrevs

@luchenlin
Copy link
Contributor Author

/issue add JDK-8223652

@openjdk
Copy link

openjdk bot commented Aug 20, 2024

@luchenlin
Adding additional issue to issue list: 8223652: Rename IPSupport.skipIfCurrentConfigurationIsInvalid().

@luchenlin luchenlin closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant