Skip to content

8266161: mark hotspot compiler/rtm tests which ignore VM flags #2911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Aug 15, 2024

I backport this for parity with 11.0.25-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8266161 needs maintainer approval

Warning

 ⚠️ Found leading lowercase letter in issue title for 8266161: mark hotspot compiler/rtm tests which ignore VM flags

Issue

  • JDK-8266161: mark hotspot compiler/rtm tests which ignore VM flags (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2911/head:pull/2911
$ git checkout pull/2911

Update a local copy of the PR:
$ git checkout pull/2911
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2911/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2911

View PR using the GUI difftool:
$ git pr show -t 2911

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2911.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 15, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 15, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 81b1502701e70c98d3d6a763808a3ae6f2dc8739 8266161: mark hotspot compiler/rtm tests which ignore VM flags Aug 15, 2024
@openjdk
Copy link

openjdk bot commented Aug 15, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 15, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 15, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 15, 2024

Webrevs

@openjdk openjdk bot added the approval label Aug 16, 2024
@GoeLin
Copy link
Member

GoeLin commented Aug 21, 2024

There are red tests.

@openjdk openjdk bot removed the approval label Aug 26, 2024
@luchenlin luchenlin closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants