8273135: java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java crashes in liblcms.dylib with NULLSeek+0x7

[mrserb]

Hi all,

This pull request contains a backport of commit 1017a2c2 from the openjdk/jdk repository.

This backport contains a patch imported to openjdk/jdk from the lcms 2.14 library in advance. Unfortunately this backport was not pushed to the jdk11u-dev as is, and not as part of the lcms update to 2.14(see #1659) as a result the implementation of the lcms library in jdk11u-dev is incomplete.

The patch is not clean, the change in the MTTransformReplacedProfile test is dropped, that test does not exist in the jdk11 and I have no plans to backport the patch which added that test.

@GoeLin please take a look.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8273135 needs maintainer approval

Issue

• JDK-8273135: java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java crashes in liblcms.dylib with NULLSeek+0x7 (Bug - P4 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2914/head:pull/2914
$ git checkout pull/2914

Update a local copy of the PR:
$ git checkout pull/2914
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2914/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2914

View PR using the GUI difftool:
$ git pr show -t 2914

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2914.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8273135: java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java crashes in liblcms.dylib with NULLSeek+0x7

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 828d645: 8314614: jdk/jshell/ImportTest.java failed with "InternalError: Failed remote listen"
• cd4ae8c: 8316973: GC: Make TestDisableDefaultGC use createTestJvm
• cd9e6cb: 8334166: Enable binary check

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (3af8378b)

[openjdk]

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[GoeLin]

There are failed test.

[mrserb]

There are failed test.

There are no failed tests, but broken builds on macos due to deprecated 'sprintf'. same problem exists in all recent PRs for jdk11u-dev.

[mrserb]

/integrate

[openjdk]

Going to push as commit a83d930.
Since your change was applied there have been 7 commits pushed to the master branch:

• c67fe36: 8325022: Incorrect error message on client authentication
• 3df1852: 8210338: Better output for GenerationTests.java
• 9ba9dd2: 8224081: SOCKS v4 tests require IPv4
• d3ce405: 8206440: Remove javac -source/-target 6 from jdk regression tests
• 828d645: 8314614: jdk/jshell/ImportTest.java failed with "InternalError: Failed remote listen"
• cd4ae8c: 8316973: GC: Make TestDisableDefaultGC use createTestJvm
• cd9e6cb: 8334166: Enable binary check

Your commit was automatically rebased without conflicts.

[openjdk]

@mrserb Pushed as commit a83d930.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.