Skip to content

8210338: Better output for GenerationTests.java#2916

Closed
amosshi wants to merge 1 commit intoopenjdk:masterfrom
amosshi:backport-8210338
Closed

8210338: Better output for GenerationTests.java#2916
amosshi wants to merge 1 commit intoopenjdk:masterfrom
amosshi:backport-8210338

Conversation

@amosshi
Copy link
Contributor

@amosshi amosshi commented Aug 21, 2024

Backport of JDK-8210338

Testing

  • Local: Test passed on MacOS 14.6.1 on Apple M1 Max
    • GenerationTests.java: Test results: passed: 1
  • Pipeline: All passed except macOS
    • macOS: /Applications/Xcode_14.3.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/stdio.h:188:1: note: 'sprintf' has been explicitly marked deprecated here The issue exists in all recent PR in jdk11u-dev and not caused by Current PR
  • Testing Machine: SAP nightlies SUCCESSFUL on 2024-08-23
    • Automated jtreg test: jtreg_jdk_tier2, Started at 2024-08-22 21:36:00+01:00
    • javax/xml/crypto/dsig/GenerationTests.java: SUCCESSFUL GitHub 📊 - [21:59:45.106 -> 127,518 msec]

Progress

  • JDK-8210338 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8210338: Better output for GenerationTests.java (Sub-task - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2916/head:pull/2916
$ git checkout pull/2916

Update a local copy of the PR:
$ git checkout pull/2916
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2916/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2916

View PR using the GUI difftool:
$ git pr show -t 2916

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2916.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 21, 2024

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 21, 2024

@amosshi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8210338: Better output for GenerationTests.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 828d645: 8314614: jdk/jshell/ImportTest.java failed with "InternalError: Failed remote listen"
  • cd4ae8c: 8316973: GC: Make TestDisableDefaultGC use createTestJvm

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport a5f7028279d61313b2293bbac3eaba0c880a7430 8210338: Better output for GenerationTests.java Aug 21, 2024
@openjdk
Copy link

openjdk bot commented Aug 21, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 21, 2024
@openjdk
Copy link

openjdk bot commented Aug 21, 2024

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 21, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 21, 2024

Webrevs

@amosshi
Copy link
Contributor Author

amosshi commented Aug 24, 2024

/approval request "Backporting for parity with 11.0.25-oracle. No risk, test fix. Clean backport. Test passes and SAP nightlies pass on 2024-08-23”

@openjdk
Copy link

openjdk bot commented Aug 24, 2024

@amosshi
8210338: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Aug 24, 2024
@amosshi
Copy link
Contributor Author

amosshi commented Aug 26, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Aug 26, 2024

Going to push as commit 3df1852.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 9ba9dd2: 8224081: SOCKS v4 tests require IPv4
  • d3ce405: 8206440: Remove javac -source/-target 6 from jdk regression tests
  • 828d645: 8314614: jdk/jshell/ImportTest.java failed with "InternalError: Failed remote listen"
  • cd4ae8c: 8316973: GC: Make TestDisableDefaultGC use createTestJvm

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 26, 2024
@openjdk openjdk bot closed this Aug 26, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 26, 2024
@openjdk
Copy link

openjdk bot commented Aug 26, 2024

@amosshi Pushed as commit 3df1852.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@amosshi amosshi deleted the backport-8210338 branch August 26, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant