-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8224081: SOCKS v4 tests require IPv4 #2917
Conversation
👋 Welcome back ashi! A progress list of the required criteria for merging this PR into |
@amosshi This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request "Backporting for parity with 11.0.25-oracle. No risk, test fix. Clean backport. Test passes and SAP nightlies pass on 2024-08-23” |
/integrate |
Going to push as commit 9ba9dd2.
Your commit was automatically rebased without conflicts. |
Backport of JDK-8224081
Testing
MacOS 14.6.1
on Apple M1 MaxSocksProxyVersion.java
: Test results: passed: 1macOS
macOS
:/Applications/Xcode_14.3.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/stdio.h:188:1: note: 'sprintf' has been explicitly marked deprecated here
The issue exists in all recent PR in jdk11u-dev and not caused by Current PR2024-08-23
jtreg_jdk_tier2
, Started at2024-08-22 21:36:00+01:00
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2917/head:pull/2917
$ git checkout pull/2917
Update a local copy of the PR:
$ git checkout pull/2917
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2917/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2917
View PR using the GUI difftool:
$ git pr show -t 2917
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2917.diff
Webrev
Link to Webrev Comment