8303920: Avoid calling out to python in DataDescriptorSignatureMissing test

[cost0much]

Clean backport that improves DataDescriptorSignatureMissing test; already backported to 17 and 21. Passes affected test in Linux x64.
MacOS GHA failing due to unrelated deprecated code during compile

---

Progress

• Change must not contain extraneous whitespace
• JDK-8303920 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8303920: Avoid calling out to python in DataDescriptorSignatureMissing test (Enhancement - P4 - Approved)

Reviewers

• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2922/head:pull/2922
$ git checkout pull/2922

Update a local copy of the PR:
$ git checkout pull/2922
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2922/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2922

View PR using the GUI difftool:
$ git pr show -t 2922

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2922.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cost0much! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@cost0much This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8303920: Avoid calling out to python in DataDescriptorSignatureMissing test

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 48 new commits pushed to the master branch:

• cf53387: 8342629: [11u] Properly message out that shenandoah is disabled
• 249144c: 8225045: javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails on linux-x64
• 04e6f37: 8247706: Unintentional use of new Date(year...) with absolute year
• add9000: 8232367: Update Reactive Streams to 1.0.3 -- tests only
• 827528c: 8339470: [17u] More defensive fix for 8163921
• 96805ae: 8224624: Inefficiencies in CodeStrings::add_comment cause timeouts
• 98161b7: 8334332: TestIOException.java fails if run by root
• 9bf5502: 8342426: [11u] javax/naming/module/RunBasic.java javac compile fails
• 8ba0341: Merge
• cee8535: 8341675: [11u] Remove designator DEFAULT_PROMOTED_VERSION_PRE=ea for release 11.0.25
• ... and 38 more: https://git.openjdk.org/jdk11u-dev/compare/828d645208f490b8a74d5e007d37bad7dcad50b1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[cost0much]

/approval request Improves the test DataDescriptorSignatureMissing added in JDK22. Applies cleanly. Affected test passes. Risk is low: the change is test code only.

[openjdk]

@cost0much
8303920: The approval request has been created successfully.

[mlbridge]

Webrevs

• 00: Full (9a2b4725)

[GoeLin]

There are failed tests.

[openjdk]

⚠️ @cost0much This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[phohensee]

MacOS GHA build failures are sprintf related, i.e., unrelated to this backport.

[cost0much]

/approval request Improves the test DataDescriptorSignatureMissing added in JDK22. Applies cleanly. Affected test passes and failing GHA is unrelated to the backport. Risk is low: the change is test code only.

[openjdk]

@cost0much
8303920: The approval request has been updated successfully.

[bridgekeeper]

@cost0much This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@cost0much This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[cost0much]

/open

[openjdk]

@cost0much This pull request is now open

[cost0much]

/integrate

[openjdk]

@cost0much This pull request has not yet been marked as ready for integration.

[phohensee]

Maintainer(s), the JBS is tagged jdk11u-fix-yes, but the bot doesn't appear to have noticed. How can we fix it?

[gnu-andrew]

Confirmed clean and updated test passes.

[cost0much]

/integrate

[openjdk]

@cost0much
Your change (at version 9a2b472) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 513a67a.
Since your change was applied there have been 48 commits pushed to the master branch:

• cf53387: 8342629: [11u] Properly message out that shenandoah is disabled
• 249144c: 8225045: javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails on linux-x64
• 04e6f37: 8247706: Unintentional use of new Date(year...) with absolute year
• add9000: 8232367: Update Reactive Streams to 1.0.3 -- tests only
• 827528c: 8339470: [17u] More defensive fix for 8163921
• 96805ae: 8224624: Inefficiencies in CodeStrings::add_comment cause timeouts
• 98161b7: 8334332: TestIOException.java fails if run by root
• 9bf5502: 8342426: [11u] javax/naming/module/RunBasic.java javac compile fails
• 8ba0341: Merge
• cee8535: 8341675: [11u] Remove designator DEFAULT_PROMOTED_VERSION_PRE=ea for release 11.0.25
• ... and 38 more: https://git.openjdk.org/jdk11u-dev/compare/828d645208f490b8a74d5e007d37bad7dcad50b1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @cost0much Pushed as commit 513a67a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.