Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak #2923

Closed
wants to merge 1 commit into from

Conversation

cost0much
Copy link
Contributor

@cost0much cost0much commented Aug 26, 2024

Clean backport that makes TestListenerLeak more robust; already backported to 17 and 21. Passes affected test on Linux x64.
MacOS GHA failing due to unrelated deprecated code during compile.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8316193 needs maintainer approval

Issue

  • JDK-8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2923/head:pull/2923
$ git checkout pull/2923

Update a local copy of the PR:
$ git checkout pull/2923
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2923/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2923

View PR using the GUI difftool:
$ git pr show -t 2923

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2923.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 26, 2024

👋 Welcome back cost0much! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 26, 2024

@cost0much This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • bec83f3: 8211920: Close server socket and cleanups in test/jdk/javax/naming/module/RunBasic.java
  • 59b3859: 8340815: Add SECURITY.md file
  • dd35f18: 8340671: GHA: Bump macOS and Xcode versions to macos-12 and XCode 13.4.1
  • b2d3859: Merge
  • 0358cbd: 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2
  • 934decc: Merge
  • 90ad5b1: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs
  • 6ee8bac: 8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods
  • ffcdc10: 8315936: Parallelize gc/stress/TestStressG1Humongous.java test
  • 76b8327: 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main
  • ... and 4 more: https://git.openjdk.org/jdk11u-dev/compare/3df18523abaf771a5ce8981dd3663f4004fefd62...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport f6be922952642f40dcf0d27b7896c9a6acdd6378 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak Aug 26, 2024
@openjdk
Copy link

openjdk bot commented Aug 26, 2024

This backport pull request has now been updated with issue from the original commit.

@cost0much
Copy link
Contributor Author

/approval request Improves the test added in JDK 22. Applies cleanly. Affected test passes. Risk is low: the change is test code only.

@openjdk
Copy link

openjdk bot commented Aug 26, 2024

@cost0much
8316193: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Aug 26, 2024
@cost0much cost0much marked this pull request as ready for review August 26, 2024 21:01
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 26, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 26, 2024

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Aug 27, 2024

There are failed tests.

@openjdk
Copy link

openjdk bot commented Aug 27, 2024

⚠️ @cost0much This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot removed the approval label Aug 27, 2024
@phohensee
Copy link
Member

MacOS GHA build failures are sprintf related, i.e., unrelated to this backport.

@cost0much
Copy link
Contributor Author

/approval request Improves the test added in JDK 22. Applies cleanly. Affected test passes; failing GHA is unrelated to the backport. Risk is low: the change is test code only.

@openjdk
Copy link

openjdk bot commented Aug 27, 2024

@cost0much
8316193: The approval request has been updated successfully.

@openjdk openjdk bot added the approval label Aug 27, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 24, 2024

@cost0much This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Sep 30, 2024
@cost0much
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 30, 2024
@openjdk
Copy link

openjdk bot commented Sep 30, 2024

@cost0much
Your change (at version 3dd9121) is now ready to be sponsored by a Committer.

@mrserb
Copy link
Member

mrserb commented Sep 30, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 30, 2024

Going to push as commit 0157967.
Since your change was applied there have been 14 commits pushed to the master branch:

  • bec83f3: 8211920: Close server socket and cleanups in test/jdk/javax/naming/module/RunBasic.java
  • 59b3859: 8340815: Add SECURITY.md file
  • dd35f18: 8340671: GHA: Bump macOS and Xcode versions to macos-12 and XCode 13.4.1
  • b2d3859: Merge
  • 0358cbd: 8296410: HttpClient throws java.io.IOException: no statuscode in response for HTTP2
  • 934decc: Merge
  • 90ad5b1: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs
  • 6ee8bac: 8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods
  • ffcdc10: 8315936: Parallelize gc/stress/TestStressG1Humongous.java test
  • 76b8327: 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main
  • ... and 4 more: https://git.openjdk.org/jdk11u-dev/compare/3df18523abaf771a5ce8981dd3663f4004fefd62...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 30, 2024
@openjdk openjdk bot closed this Sep 30, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 30, 2024
@openjdk
Copy link

openjdk bot commented Sep 30, 2024

@mrserb @cost0much Pushed as commit 0157967.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants