-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak #2923
Conversation
👋 Welcome back cost0much! A progress list of the required criteria for merging this PR into |
@cost0much This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 14 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
/approval request Improves the test added in JDK 22. Applies cleanly. Affected test passes. Risk is low: the change is test code only. |
@cost0much |
There are failed tests. |
|
MacOS GHA build failures are sprintf related, i.e., unrelated to this backport. |
/approval request Improves the test added in JDK 22. Applies cleanly. Affected test passes; failing GHA is unrelated to the backport. Risk is low: the change is test code only. |
@cost0much |
@cost0much This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
/integrate |
@cost0much |
/sponsor |
Going to push as commit 0157967.
Your commit was automatically rebased without conflicts. |
@mrserb @cost0much Pushed as commit 0157967. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Clean backport that makes TestListenerLeak more robust; already backported to 17 and 21. Passes affected test on Linux x64.
MacOS GHA failing due to unrelated deprecated code during compile.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2923/head:pull/2923
$ git checkout pull/2923
Update a local copy of the PR:
$ git checkout pull/2923
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2923/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2923
View PR using the GUI difftool:
$ git pr show -t 2923
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2923.diff
Webrev
Link to Webrev Comment