-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8340671: GHA: Bump macOS and Xcode versions to macos-12 and XCode 13.4.1 #2940
Conversation
👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into |
@vieiro This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
/approval request This is a first step to bring back online the os-x builds and tests in GHA for jdk11u-dev. |
|
/integrate |
/sponsor |
The macos-11 github runners were deprecated and removed in June 2024 , making the macos tests to hang in openjdk11u-dev (and other OpenJDK repositories).
JDK-8335793 GHA: Bump macOS and Xcode versions upgraded the version #2835 of mac runners to macos-13. This upgrade in github runners required a long list of changes in openjdk11u-dev that proved difficult to review.
In order to ease the review process this PR downgrades the version of github runners in jdk11u-dev from the current macos-13 to macos-12 and xcode-13.4.1. This will require a single backport of JDK-8299254 Support dealing with standard assert macro (a follow-up to this PR), making the review process easier.
Once the github actions are running again in macos-12 an upgrade to macos-13 could be performed, if required, with some more additional PRs.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2940/head:pull/2940
$ git checkout pull/2940
Update a local copy of the PR:
$ git checkout pull/2940
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2940/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2940
View PR using the GUI difftool:
$ git pr show -t 2940
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2940.diff
Webrev
Link to Webrev Comment