8211920: Close server socket and cleanups in test/jdk/javax/naming/module/RunBasic.java

[mrserb]

Hi all,

This pull request contains a backport of commit e61252dc from the openjdk/jdk repository.

The commit being backported was authored by Chris Hegarty on 9 Oct 2018 and was reviewed by Daniel Fuchs.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8211920 needs maintainer approval

Issue

• JDK-8211920: Close server socket and cleanups in test/jdk/javax/naming/module/RunBasic.java (Sub-task - P4 - Approved)

Reviewers

• Yuri Nesterenko (@yan-too - Reviewer)
• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2942/head:pull/2942
$ git checkout pull/2942

Update a local copy of the PR:
$ git checkout pull/2942
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2942/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2942

View PR using the GUI difftool:
$ git pr show -t 2942

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2942.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8211920: Close server socket and cleanups in test/jdk/javax/naming/module/RunBasic.java

Reviewed-by: yan, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 59b3859: 8340815: Add SECURITY.md file

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mrserb]

The build issue on macOS x64/aarch64 is due to #2937

[mlbridge]

Webrevs

• 00: Full (c5310bcc)

[gnu-andrew]

Confirmed clean.

[mrserb]

/integrate

[openjdk]

Going to push as commit bec83f3.
Since your change was applied there has been 1 commit pushed to the master branch:

• 59b3859: 8340815: Add SECURITY.md file

Your commit was automatically rebased without conflicts.

[openjdk]

@mrserb Pushed as commit bec83f3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.