Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263490: [macos] Crash occurs on JPasswordField with activated InputMethod #295

Closed
wants to merge 1 commit into from

Conversation

toshiona
Copy link
Contributor

@toshiona toshiona commented Aug 25, 2021

Hi,

Original patch almost applies cleanly to 11u. Only copyright year was adjusted.
This crash issue with Input Method of GUI was observed with 11.0.12, and I'd like to backport it.

Original bug: https://bugs.openjdk.java.net/browse/JDK-8263490

Testing: tier1, java/awt and javax/swing on macOS


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263490: [macos] Crash occurs on JPasswordField with activated InputMethod

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/295/head:pull/295
$ git checkout pull/295

Update a local copy of the PR:
$ git checkout pull/295
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/295/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 295

View PR using the GUI difftool:
$ git pr show -t 295

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/295.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 25, 2021

👋 Welcome back tnakamura! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 32c7fcc67010e44411918cc73681422fd8b7a67a 8263490: [macos] Crash occurs on JPasswordField with activated InputMethod Aug 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 25, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Aug 25, 2021
@toshiona toshiona marked this pull request as ready for review Aug 25, 2021
@openjdk openjdk bot added the rfr label Aug 25, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 25, 2021

Webrevs

Copy link
Contributor

@shipilev shipilev left a comment

The patch looks fine.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 26, 2021

@toshiona This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8263490: [macos] Crash occurs on JPasswordField with activated InputMethod

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Aug 26, 2021
@toshiona
Copy link
Contributor Author

@toshiona toshiona commented Aug 27, 2021

Thank you for the review, @shipilev
Got the approval label.
Can anyone sponsor this?

@toshiona
Copy link
Contributor Author

@toshiona toshiona commented Aug 27, 2021

/integrate

@openjdk openjdk bot added the sponsor label Aug 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 27, 2021

@toshiona
Your change (at version 6e913e5) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Aug 27, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Aug 27, 2021

Going to push as commit 45ed9e8.
Since your change was applied there have been 36 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 27, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Aug 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 27, 2021

@RealCLanger @toshiona Pushed as commit 45ed9e8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
3 participants