-
Notifications
You must be signed in to change notification settings - Fork 238
8263490: [macos] Crash occurs on JPasswordField with activated InputMethod #295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back tnakamura! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The patch looks fine.
@toshiona This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 36 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Thank you for the review, @shipilev |
/integrate |
/sponsor |
Going to push as commit 45ed9e8.
Your commit was automatically rebased without conflicts. |
@RealCLanger @toshiona Pushed as commit 45ed9e8. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi,
Original patch almost applies cleanly to 11u. Only copyright year was adjusted.
This crash issue with Input Method of GUI was observed with 11.0.12, and I'd like to backport it.
Original bug: https://bugs.openjdk.java.net/browse/JDK-8263490
Testing: tier1, java/awt and javax/swing on macOS
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/295/head:pull/295
$ git checkout pull/295
Update a local copy of the PR:
$ git checkout pull/295
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/295/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 295
View PR using the GUI difftool:
$ git pr show -t 295
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/295.diff