Skip to content

8224624: Inefficiencies in CodeStrings::add_comment cause timeouts #2951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sendaoYan wants to merge 2 commits into from
Closed

8224624: Inefficiencies in CodeStrings::add_comment cause timeouts #2951

sendaoYan wants to merge 2 commits into from

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Oct 15, 2024 •
edited by openjdk bot
Loading

Hi all,
This is prefix backport of JDK-8231058, after apply this backport will make backport of JDK-8231058 cleanly.
This PR improves C1 compiled time of the test compiler/c1/TestLinearScanOrderMain.java method dramatically from 92s to 1.8s, and solve this test intermittent timeout.

Additonal testing:

  • linux aarch64 build with release/slowdebug configure
  • linux x86_64 build with release/slowdebug configure
  • jtreg tests(include tier1/2/3 etc.) with release build on linux aarch64
  • jtreg tests(include tier1/2/3 etc.) with release build on linux x86_64

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8224624 needs maintainer approval

Issue

  • JDK-8224624: Inefficiencies in CodeStrings::add_comment cause timeouts (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2951/head:pull/2951
$ git checkout pull/2951

Update a local copy of the PR:
$ git checkout pull/2951
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2951/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2951

View PR using the GUI difftool:
$ git pr show -t 2951

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2951.diff

Using Webrev

Link to Webrev Comment

@TobiHartmann
8224624: Inefficiencies in CodeStrings::add_comment cause timeouts
97890d5 
Changing CodeStrings to a doubly-linked-list and searching for the comment with the right offset in reverse.

Reviewed-by: kvn
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 15, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 15, 2024 •
edited
Loading

@sendaoYan This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8224624: Inefficiencies in CodeStrings::add_comment cause timeouts

Changing CodeStrings to a doubly-linked-list and searching for the comment with the right offset in reverse.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 7cff981f5a3aa192e57545c7df069fb48ba69edf 8224624: Inefficiencies in CodeStrings::add_comment cause timeouts Oct 15, 2024
@openjdk
Copy link

openjdk bot commented Oct 15, 2024

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 15, 2024
@openjdk
Copy link

openjdk bot commented Oct 15, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 15, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 15, 2024 •
edited
Loading

Webrevs

@sendaoYan
Copy link
Member Author

sendaoYan commented Oct 15, 2024

The GHA report macos-x64 and macos-aarch64 build fails error: 'sprintf' is deprecated, which has been recorded by JDK-8296812. The build fails is unreleated to this PR.

@sendaoYan
Copy link
Member Author

sendaoYan commented Oct 15, 2024

/approval request Clean backport to improves C1 compiled time and fix the test imtermittent timeout.

@openjdk
Copy link

openjdk bot commented Oct 15, 2024

@sendaoYan
8224624: The approval request has been created successfully.

@sendaoYan
Copy link
Member Author

sendaoYan commented Oct 15, 2024

/approval request Clean backport to improves C1 compiled time and fix the test imtermittent timeout. Jtreg tests(include tier1/2/3 etc.) passed on linux x64 and linux aarch64.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 15, 2024
@openjdk
Copy link

openjdk bot commented Oct 15, 2024

@sendaoYan
8224624: The approval request has been updated successfully.

@vieiro
Copy link
Contributor

vieiro commented Oct 15, 2024

The GHA report macos-x64 and macos-aarch64 build fails error: 'sprintf' is deprecated, which has been recorded by JDK-8296812. The build fails is unreleated to this PR.

Hi @sendaoYan , please note that GHA for macos-x64 and macos-aarch64 must pass after #2940 was merged.

@sendaoYan
Copy link
Member Author

sendaoYan commented Oct 15, 2024

The GHA report macos-x64 and macos-aarch64 build fails error: 'sprintf' is deprecated, which has been recorded by JDK-8296812. The build fails is unreleated to this PR.

Hi @sendaoYan , please note that GHA for macos-x64 and macos-aarch64 must pass after #2940 was merged.

Sorry, I forgot update the baseline from jdk11u-dev. I will update and run the GHA test again.

@sendaoYan
Copy link
Member Author

sendaoYan commented Oct 15, 2024

GHA all passed.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Nov 8, 2024
@sendaoYan
Copy link
Member Author

sendaoYan commented Nov 8, 2024

Thanks for the approved.

/integrate

@openjdk
Copy link

openjdk bot commented Nov 8, 2024

Going to push as commit 96805ae.
Since your change was applied there have been 17 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 8, 2024
@openjdk openjdk bot closed this Nov 8, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 8, 2024
@openjdk
Copy link

openjdk bot commented Nov 8, 2024

@sendaoYan Pushed as commit 96805ae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan sendaoYan deleted the jbs8224624 branch November 8, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sendaoYan @vieiro @TobiHartmann