-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8195675: Call to insertText with single character from custom Input Method ignored #2954
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back srl! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
|
/approval |
@srl295 usage: |
Webrevs
|
/approval request java.awt components did not work properly on macOS with custom input methods, the net effect is that minority language keyboards did not work properly with Java. Low risk, the fix handles this situation similarly to how Apple's own 'kotoeri' input method was handled on a long term basis, so it is a well-worn path. Patch should apply cleanly and was code reviewed |
|
@srl295 Could not automatically backport b8f2ec90 to openjdk/jdk11u-dev due to conflicts in the following files:
src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.m
Please fetch the appropriate branch/commit and manually resolve these conflicts by using the following commands in your personal fork of openjdk/jdk11u-dev. Note: these commands are just some suggestions and you can use other equivalent commands you know.
Fetch the up-to-date version of the target branch
$ git fetch --no-tags https://git.openjdk.org/jdk11u-dev.git master:master
Check out the target branch and create your own branch to backport
$ git checkout master
$ git checkout -b backport-srl295-b8f2ec90-master
Fetch the commit you want to backport
$ git fetch --no-tags https://git.openjdk.org/jdk.git b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd
Backport the commit
$ git cherry-pick --no-commit b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd
Resolve conflicts now
Commit the files you have modified
$ git add files/with/resolved/conflicts
$ git commit -m 'Backport b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd'
Once you have resolved the conflicts as explained above continue with creating a pull request towards the openjdk/jdk11u-dev with the title Backport b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd.
Below you can find a suggestion for the pull request body:
Hi all,
This pull request contains a backport of commit b8f2ec90 from the openjdk/jdk repository.
The commit being backported was authored by Steven Loomis on 28 May 2024 and was reviewed by Phil Race.
PR: openjdk/jdk#17921
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2954/head:pull/2954
$ git checkout pull/2954
Update a local copy of the PR:
$ git checkout pull/2954
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2954/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2954
View PR using the GUI difftool:
$ git pr show -t 2954
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2954.diff
Using Webrev
Link to Webrev Comment