New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8241336: Some java.net tests failed with NoRouteToHostException on MacOS with special network configuration #296
Conversation
👋 Welcome back clanger! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue and summary from the original commit. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The patch looks fine. Do you see this failing in 11u? (I just wonder why Oracle had not backported this yet).
@RealCLanger This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
… part of JDK-8220673 which is not backported.
I added another small commit to add a test library annotation for Promiscious.java. Now it should work. And, yes, we see these kind of errors in 11 now, too. Probably we have a special configuration in our 11 test landscape now that Oracle hasn't. |
/integrate |
Going to push as commit c816276.
Your commit was automatically rebased without conflicts. |
@RealCLanger Pushed as commit c816276. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Unclean backport of JDK-8241336. We seem to have a new Mac configuration in our test landscape that exhibits these failures in JDK11, too.
Changes to problem list do not apply.
Promiscious.java needs an "@library /test/lib" annotation because JDK-8220673 was not backported.
AdaptorMulticasting.java does not exist in 11
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/296/head:pull/296
$ git checkout pull/296
Update a local copy of the PR:
$ git checkout pull/296
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/296/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 296
View PR using the GUI difftool:
$ git pr show -t 296
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/296.diff