Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8241336: Some java.net tests failed with NoRouteToHostException on MacOS with special network configuration #296

Closed
wants to merge 2 commits into from

Conversation

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Aug 25, 2021

Unclean backport of JDK-8241336. We seem to have a new Mac configuration in our test landscape that exhibits these failures in JDK11, too.

Changes to problem list do not apply.
Promiscious.java needs an "@library /test/lib" annotation because JDK-8220673 was not backported.
AdaptorMulticasting.java does not exist in 11


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8241336: Some java.net tests failed with NoRouteToHostException on MacOS with special network configuration

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/296/head:pull/296
$ git checkout pull/296

Update a local copy of the PR:
$ git checkout pull/296
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/296/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 296

View PR using the GUI difftool:
$ git pr show -t 296

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/296.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 25, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5ddbcb7a515e29d805df17ca2977eeb720adef29 8241336: Some java.net tests failed with NoRouteToHostException on MacOS with special network configuration Aug 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 25, 2021

This backport pull request has now been updated with issue and summary from the original commit.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 25, 2021

Webrevs

Copy link
Contributor

@shipilev shipilev left a comment

The patch looks fine. Do you see this failing in 11u? (I just wonder why Oracle had not backported this yet).

@openjdk
Copy link

@openjdk openjdk bot commented Aug 26, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8241336: Some java.net tests failed with NoRouteToHostException on MacOS with special network configuration

NetworkConfiguration updated to skip interfaces that have only IPv6 link local addresses.

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 5d1b9bb: 8233790: Forward output from heap dumper to jcmd/jmap
  • 9012b4a: Merge
  • e261bf7: Merge
  • 7cafcf4: 8252857: AArch64: Shenandoah C1 CAS is not sequentially consistent
  • 09f3707: 8261846: [JVMCI] c2v_iterateFrames can get out of sync with the StackFrameStream
  • 1f6eb0f: 8264016: [JVMCI] add some thread local fields for use by JVMCI
  • 3bc2275: 8263776: [JVMCI] add helper to perform Java upcalls

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 26, 2021
… part of JDK-8220673 which is not backported.
@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Aug 26, 2021

The patch looks fine. Do you see this failing in 11u? (I just wonder why Oracle had not backported this yet).

I added another small commit to add a test library annotation for Promiscious.java. Now it should work. And, yes, we see these kind of errors in 11 now, too. Probably we have a special configuration in our 11 test landscape now that Oracle hasn't.

@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Aug 27, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Aug 27, 2021

Going to push as commit c816276.
Since your change was applied there have been 15 commits pushed to the master branch:

  • 910e24b: 8212718: Refactor some annotation processor tests to better use collections
  • 5792854: 8212695: Add explicit timeout to several HTTP Client tests
  • e5ec679: 8211325: test/jdk/java/net/Socket/LingerTest.java fails with cleaning up
  • 7100a65: 8169246: java/net/DatagramSocket/ReportSocketClosed.java fails intermittently with BindException
  • 069b4cc: 8199931: java/net/MulticastSocket/UnreferencedMulticastSockets.java fails with "incorrect data received"
  • 45ed9e8: 8263490: [macos] Crash occurs on JPasswordField with activated InputMethod
  • 7c872ed: 8272124: Cgroup v1 initialization causes NullPointerException when cgroup path contains colon
  • cb0775f: 8269934: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in java_lang_Thread::get_thread_status
  • 5d1b9bb: 8233790: Forward output from heap dumper to jcmd/jmap
  • 9012b4a: Merge
  • ... and 5 more: https://git.openjdk.java.net/jdk11u-dev/compare/7539e75845902bbd3bc61066e6c8f21abb6d6631...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 27, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 27, 2021

@RealCLanger Pushed as commit c816276.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the backport-8241336 branch Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants