You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This pull request contains a backport of commit 571c435e from the openjdk/jdk repository.
The commit being backported was authored by Jan Kratochvil on 23 Aug 2023 and was reviewed by Erik Joelsson.
Without this PR, the jdk build with --enable-ccache can't generate comments in -XX:+PrintInterpreter, this PR fix the build issue. So I want to backport this PR to jdk11u-dev from jdk22.
👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.
This backport pull request has now been updated with issue from the original commit.
openjdkbot
added
backport
Port of a pull request already in a different code base
clean
Identical backport; no merge resolution required
labels
Nov 5, 2024
⚠️@sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.
/approval request Clean backport to fix build bug with --enable-ccache. Without this PR, the jdk build with --enable-ccache can't generate comments with JVM option -XX:+PrintInterpreter, this PR will fix the build issue. So I want to backport this PR to jdk11u-dev from jdk22.
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
/approval request Clean backport to fix build bug with --enable-ccache. Without this PR, the jdk build with --enable-ccache can't generate comments with JVM option -XX:+PrintInterpreter, this PR will fix the build issue. So I want to backport this PR to jdk11u-dev from jdk22.
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
@sendaoYan This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
approvalRequires approval; will be removed when approval is receivedbackportPort of a pull request already in a different code basecleanIdentical backport; no merge resolution requiredrfrPull request is ready for review
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
This pull request contains a backport of commit 571c435e from the openjdk/jdk repository.
The commit being backported was authored by Jan Kratochvil on 23 Aug 2023 and was reviewed by Erik Joelsson.
Without this PR, the jdk build with --enable-ccache can't generate comments in -XX:+PrintInterpreter, this PR fix the build issue. So I want to backport this PR to jdk11u-dev from jdk22.
Thanks!
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2960/head:pull/2960$ git checkout pull/2960Update a local copy of the PR:
$ git checkout pull/2960$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2960/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2960View PR using the GUI difftool:
$ git pr show -t 2960Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2960.diff
Using Webrev
Link to Webrev Comment