Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269993: [Test]: java/net/httpclient/DigestEchoClientSSL.java contains redundant @run tags #298

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Aug 27, 2021

Clean backport of JDK-8269993.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8269993: [Test]: java/net/httpclient/DigestEchoClientSSL.java contains redundant @run tags

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/298/head:pull/298
$ git checkout pull/298

Update a local copy of the PR:
$ git checkout pull/298
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/298/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 298

View PR using the GUI difftool:
$ git pr show -t 298

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/298.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 27, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4e18ec26ddfa0b44e8780ebd556a5e8aa2e90dc0 8269993: [Test]: java/net/httpclient/DigestEchoClientSSL.java contains redundant @run tags Aug 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 27, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 27, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8269993: [Test]: java/net/httpclient/DigestEchoClientSSL.java contains redundant @run tags

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • c816276: 8241336: Some java.net tests failed with NoRouteToHostException on MacOS with special network configuration

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Aug 27, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 27, 2021

Webrevs

@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Sep 7, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 7, 2021

Going to push as commit 2de01c1.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 47e4bc9: 8269984: [macos] JTabbedPane title looks like disabled
  • 569688f: 8272316: Wrong Boot JDK help message in 11
  • 1645dbe: 8262731: [macOS] Exception from "Printable.print" is swallowed during "PrinterJob.print"
  • 9efd897: 8261236: C2: ClhsdbJstackXcompStress test fails when StressGCM is enabled
  • 2908bbd: 8270216: [macOS] Update named used for Java run loop mode
  • ea1a1d8: 8251377: [macos11] JTabbedPane selected tab text is barely legible
  • 9a5ba0b: 7179006: [macosx] Print-to-file doesn't work: printing to the default printer instead
  • d41b37f: 8263362: Avoid division by 0 in java/awt/font/TextJustifier.java justify
  • 0ea1e0f: 8272902: Bump update version for OpenJDK: jdk-11.0.14
  • 63fc945: 8248668: AArch64: Avoid MIN/MAX macros when using MSVC
  • ... and 2 more: https://git.openjdk.java.net/jdk11u-dev/compare/910e24b23205b680c6367785528bfd7d79311ac8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 7, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 7, 2021

@RealCLanger Pushed as commit 2de01c1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the RealCLanger-backport-4e18ec26 branch Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant