Skip to content

Conversation

@vieiro
Copy link
Contributor

@vieiro vieiro commented Jan 2, 2025

Backport of JDK-8341424 and companion JDK-8342704

This collects hs_errs when they happen with GitHub Actions, which may be useful during reviews.

Low risk, as this affects GHA actions only. GHA builds and tests run correctly.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8342704 needs maintainer approval
  • JDK-8341424 needs maintainer approval

Issues

  • JDK-8341424: GHA: Collect hs_errs from build time failures (Enhancement - P4 - Approved)
  • JDK-8342704: GHA: Report truncation is broken after JDK-8341424 (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2982/head:pull/2982
$ git checkout pull/2982

Update a local copy of the PR:
$ git checkout pull/2982
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2982/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2982

View PR using the GUI difftool:
$ git pr show -t 2982

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2982.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 2, 2025

👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 2, 2025

@vieiro This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8341424: GHA: Collect hs_errs from build time failures
8342704: GHA: Report truncation is broken after JDK-8341424

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • bbe28d9: 8347965: (tz) Update Timezone Data to 2025a
  • 8322c66: 8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs
  • 7dab5fe: 8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x
  • 52c8606: 8339560: Unaddressed comments during code review of JDK-8337664
  • cde3642: 8339931: Update problem list for WindowUpdateFocusabilityTest.java
  • 33d19c4: 8195675: Call to insertText with single character from custom Input Method ignored
  • 6a9eb07: 8343786: [11u] GHA: Bump macOS and Xcode versions to macos-13 and XCode 14.3.1
  • 46ef0f6: 8331863: DUIterator_Fast used before it is constructed
  • c67732a: 8340387: Update OS detection code to recognize Windows Server 2025
  • ecff933: 8344589: Update IANA Language Subtag Registry to Version 2024-11-19
  • ... and 10 more: https://git.openjdk.org/jdk11u-dev/compare/a47c72fad455bfdf9053cb8e94c99e73965ab50d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 3bc06ab80f09b57dc10b182d9bc1ab1584cf6706 8341424: GHA: Collect hs_errs from build time failures Jan 2, 2025
@openjdk
Copy link

openjdk bot commented Jan 2, 2025

This backport pull request has now been updated with issues from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jan 2, 2025
@openjdk
Copy link

openjdk bot commented Jan 2, 2025

⚠️ @vieiro This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 2, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 2, 2025

Webrevs

@vieiro
Copy link
Contributor Author

vieiro commented Jan 2, 2025

Build failures are unrelated and are due to

@vieiro
Copy link
Contributor Author

vieiro commented Jan 2, 2025

/approval request Let's keep these hs_err files when they are generated. This may prove valuable in the future.

@openjdk
Copy link

openjdk bot commented Jan 2, 2025

@vieiro
8341424: The approval request has been created successfully.
8342704: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Jan 2, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 30, 2025

@vieiro This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@vieiro
Copy link
Contributor Author

vieiro commented Feb 14, 2025

Let's keep this open. It may prove valuable in the future.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Feb 20, 2025
@vieiro
Copy link
Contributor Author

vieiro commented Feb 20, 2025

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 20, 2025
@openjdk
Copy link

openjdk bot commented Feb 20, 2025

@vieiro
Your change (at version bb053f4) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 20, 2025

Going to push as commit dba357f.
Since your change was applied there have been 20 commits pushed to the master branch:

  • bbe28d9: 8347965: (tz) Update Timezone Data to 2025a
  • 8322c66: 8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs
  • 7dab5fe: 8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x
  • 52c8606: 8339560: Unaddressed comments during code review of JDK-8337664
  • cde3642: 8339931: Update problem list for WindowUpdateFocusabilityTest.java
  • 33d19c4: 8195675: Call to insertText with single character from custom Input Method ignored
  • 6a9eb07: 8343786: [11u] GHA: Bump macOS and Xcode versions to macos-13 and XCode 14.3.1
  • 46ef0f6: 8331863: DUIterator_Fast used before it is constructed
  • c67732a: 8340387: Update OS detection code to recognize Windows Server 2025
  • ecff933: 8344589: Update IANA Language Subtag Registry to Version 2024-11-19
  • ... and 10 more: https://git.openjdk.org/jdk11u-dev/compare/a47c72fad455bfdf9053cb8e94c99e73965ab50d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 20, 2025
@openjdk openjdk bot closed this Feb 20, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 20, 2025
@openjdk
Copy link

openjdk bot commented Feb 20, 2025

@phohensee @vieiro Pushed as commit dba357f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants