-
Notifications
You must be signed in to change notification settings - Fork 251
8341424: GHA: Collect hs_errs from build time failures #2982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into |
|
@vieiro This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 20 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issues from the original commit. |
|
|
|
Build failures are unrelated and are due to
|
|
/approval request Let's keep these hs_err files when they are generated. This may prove valuable in the future. |
|
@vieiro This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
Let's keep this open. It may prove valuable in the future. |
|
/integrate |
|
/sponsor |
|
Going to push as commit dba357f.
Your commit was automatically rebased without conflicts. |
|
@phohensee @vieiro Pushed as commit dba357f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport of JDK-8341424 and companion JDK-8342704
This collects hs_errs when they happen with GitHub Actions, which may be useful during reviews.
Low risk, as this affects GHA actions only. GHA builds and tests run correctly.
Progress
Issues
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2982/head:pull/2982$ git checkout pull/2982Update a local copy of the PR:
$ git checkout pull/2982$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2982/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2982View PR using the GUI difftool:
$ git pr show -t 2982Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2982.diff
Using Webrev
Link to Webrev Comment