-
Notifications
You must be signed in to change notification settings - Fork 251
8336012: Fix usages of jtreg-reserved properties #2984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back RadekCap! A progress list of the required criteria for merging this PR into |
|
@RadekCap This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
Webrevs
|
|
/approval a clean backport to fix usages of jtreg-reserved properties |
|
@RadekCap usage: |
|
/approval request a clean backport to fix usages of jtreg-reserved properties |
|
|
/integrate |
|
/sponsor |
|
@zzambers Only Committers are allowed to sponsor changes. |
|
/sponsor |
|
@phohensee @RadekCap Pushed as commit 86a1b52. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport of JDK-8336012 - Fix usages of jtreg-reserved properties
It's fixing the java/lang/invoke/PrivateInvokeTest.java#PrivateInvokeTest failure.
Clean backport.
Passed tier 1 tests.
Passed gtests.
GH Actions are passing (aside from deprecated MacOSes).
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2984/head:pull/2984$ git checkout pull/2984Update a local copy of the PR:
$ git checkout pull/2984$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2984/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2984View PR using the GUI difftool:
$ git pr show -t 2984Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2984.diff
Using Webrev
Link to Webrev Comment