Skip to content

Conversation

@RadekCap
Copy link
Contributor

@RadekCap RadekCap commented Jan 9, 2025

Backport of JDK-8336012 - Fix usages of jtreg-reserved properties

It's fixing the java/lang/invoke/PrivateInvokeTest.java#PrivateInvokeTest failure.

Clean backport.
Passed tier 1 tests.
Passed gtests.

GH Actions are passing (aside from deprecated MacOSes).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8336012 needs maintainer approval

Issue

  • JDK-8336012: Fix usages of jtreg-reserved properties (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2984/head:pull/2984
$ git checkout pull/2984

Update a local copy of the PR:
$ git checkout pull/2984
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2984/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2984

View PR using the GUI difftool:
$ git pr show -t 2984

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2984.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 9, 2025

👋 Welcome back RadekCap! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 9, 2025

@RadekCap This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8336012: Fix usages of jtreg-reserved properties

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • be6956b: 8273914: Indy string concat changes order of operations

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 98526a632076775d0d7dba28a1e083ef348bc82a 8336012: Fix usages of jtreg-reserved properties Jan 9, 2025
@openjdk
Copy link

openjdk bot commented Jan 9, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jan 9, 2025
@openjdk
Copy link

openjdk bot commented Jan 9, 2025

⚠️ @RadekCap This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 9, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 9, 2025

Webrevs

@RadekCap
Copy link
Contributor Author

RadekCap commented Jan 9, 2025

/approval a clean backport to fix usages of jtreg-reserved properties

@openjdk
Copy link

openjdk bot commented Jan 9, 2025

@RadekCap usage: /approval [<id>] (request|cancel) [<text>]

@RadekCap
Copy link
Contributor Author

RadekCap commented Jan 9, 2025

/approval request a clean backport to fix usages of jtreg-reserved properties

@openjdk
Copy link

openjdk bot commented Jan 9, 2025

@RadekCap
8336012: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Jan 9, 2025
@openjdk
Copy link

openjdk bot commented Jan 15, 2025

⚠️ @RadekCap the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout JDK-8336012
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jan 15, 2025
@RadekCap
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 21, 2025
@openjdk
Copy link

openjdk bot commented Jan 21, 2025

@RadekCap
Your change (at version 96ffa3f) is now ready to be sponsored by a Committer.

@zzambers
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 21, 2025

@zzambers Only Committers are allowed to sponsor changes.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 21, 2025

Going to push as commit 86a1b52.
Since your change was applied there has been 1 commit pushed to the master branch:

  • be6956b: 8273914: Indy string concat changes order of operations

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 21, 2025
@openjdk openjdk bot closed this Jan 21, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 21, 2025
@openjdk openjdk bot removed the sponsor Pull request is ready to be sponsored label Jan 21, 2025
@openjdk
Copy link

openjdk bot commented Jan 21, 2025

@phohensee @RadekCap Pushed as commit 86a1b52.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RadekCap RadekCap deleted the JDK-8336012 branch May 7, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants