Skip to content

Conversation

@jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Jun 14, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8241353: NPE in ToolProvider.getSystemJavaCompiler

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/30/head:pull/30
$ git checkout pull/30

Update a local copy of the PR:
$ git checkout pull/30
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/30/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30

View PR using the GUI difftool:
$ git pr show -t 30

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/30.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 14, 2021

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6b4b676550c2eaf38afcbc5820796f586edc4f1e 8241353: NPE in ToolProvider.getSystemJavaCompiler Jun 14, 2021
@openjdk
Copy link

openjdk bot commented Jun 14, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 14, 2021
@openjdk
Copy link

openjdk bot commented Jun 14, 2021

@jerboaa This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8241353: NPE in ToolProvider.getSystemJavaCompiler

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 37f36d5: 8265836: OperatingSystemImpl.getCpuLoad() returns incorrect CPU load inside a container
  • 9dc8826: 8254244: Some code emitted by TemplateTable::branch is unused when running TieredCompilation
  • d31ceee: 8253048: AArch64: When CallLeaf, no need to preserve callee-saved registers in caller
  • 941ad85: 8262392: Update Mesa 3-D Headers to version 21.0.3
  • 624e91b: 8247469: getSystemCpuLoad() returns -1 on linux when some offline cpus are present and cpusets.effective_cpus is not available
  • 6deb21f: 8196092: javax/swing/JComboBox/8032878/bug8032878.java fails
  • d3a5ed2: 8267773: PhaseStringOpts::int_stringSize doesn't handle min_jint correctly

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 14, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 14, 2021

Webrevs

@jerboaa
Copy link
Contributor Author

jerboaa commented Jun 21, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Jun 21, 2021

Going to push as commit cfdfee7.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 0605504: 8181313: SA: Remove libthread_db dependency on Linux
  • 23719ae: 8262000: jdk/jfr/event/gc/detailed/TestPromotionFailedEventWithParallelScavenge.java failed with "OutOfMemoryError: Java heap space"
  • 9638c41: 8266288: assert root method not found in witnessed_reabstraction_in_supers is too strong
  • 57d8e1e: 8268127: Shenandoah: Heap size may be too small for region to align to large page size
  • 4e19090: 8268103: JNI functions incorrectly return a double after JDK-8265836
  • 37f36d5: 8265836: OperatingSystemImpl.getCpuLoad() returns incorrect CPU load inside a container
  • 9dc8826: 8254244: Some code emitted by TemplateTable::branch is unused when running TieredCompilation
  • d31ceee: 8253048: AArch64: When CallLeaf, no need to preserve callee-saved registers in caller
  • 941ad85: 8262392: Update Mesa 3-D Headers to version 21.0.3
  • 624e91b: 8247469: getSystemCpuLoad() returns -1 on linux when some offline cpus are present and cpusets.effective_cpus is not available
  • ... and 2 more: https://git.openjdk.java.net/jdk11u-dev/compare/f55ef1e033a769101e383792c3964da275fd4582...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 21, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 21, 2021
@openjdk
Copy link

openjdk bot commented Jun 21, 2021

@jerboaa Pushed as commit cfdfee7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant