-
Notifications
You must be signed in to change notification settings - Fork 251
8327476: Upgrade JLine to 3.26.1 #3010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into |
|
@vieiro This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 13 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
Test failure of |
|
/approval request Please approve this upgrade to JLine to 3.26.1. Low/medium risk. Linux/Windows specific tests pass. This is labelled CPU25_04-critical-SQE-OK but didn't make it to the appropriate 25/04 window for 11 because it required rework on other JDK versions. |
|
/integrate |
|
/sponsor |
|
Going to push as commit c4a7b2c.
Your commit was automatically rebased without conflicts. |
Clean backport of JDK-8327476 from JDK17 that upgrades JLine to 3.26.1 (parity with 11.0.27-oracle). This is tagged as
CPU25_04-critical-SQE-OK.Tested with tier1 tests on Linux...
And with the following on Linux and Windows 11:
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3010/head:pull/3010$ git checkout pull/3010Update a local copy of the PR:
$ git checkout pull/3010$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3010/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3010View PR using the GUI difftool:
$ git pr show -t 3010Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3010.diff
Using Webrev
Link to Webrev Comment